The following document contains the results of Checkstyle 6.2 with sun_checks.xml ruleset. 
| Category | Rule | Violations | Severity |
|---|---|---|---|
| blocks | LeftCurly | 21 | |
| RightCurly | 3 | ||
| coding | AvoidInlineConditionals | 2 | |
| HiddenField | 22 | ||
| MagicNumber | 6 | ||
| design | DesignForExtension | 44 | |
| VisibilityModifier | 18 | ||
| imports | AvoidStarImport | 4 | |
| javadoc | JavadocMethod | 28 | |
| JavadocPackage | 2 | ||
| JavadocStyle | 1 | ||
| JavadocType | 9 | ||
| JavadocVariable | 40 | ||
| misc | FinalParameters | 25 | |
| naming | TypeName | 4 | |
| regexp | RegexpSingleline
|
38 | |
| sizes | LineLength | 2 | |
| whitespace | FileTabCharacter | 9 | |
| OperatorWrap | 2 | ||
| ParenPad | 1 | ||
| WhitespaceAround | 107 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.persistence.*. | 7 | |
| javadoc | JavadocType | Missing a Javadoc comment. | 9 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 9 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 9 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 11 | |
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 11 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 17 | |
| sizes | LineLength | Line is longer than 80 characters (found 105). | 19 | |
| sizes | LineLength | Line is longer than 80 characters (found 92). | 20 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 27 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 27 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 30 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 31 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 31 | |
| whitespace | ParenPad | ')' is preceded with whitespace. | 31 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 36 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 36 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 36 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 39 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 39 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 39 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 39 | |
| coding | MagicNumber | '16' is a magic number. | 39 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 39 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 39 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 39 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 41 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 42 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 42 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 42 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 42 | |
| coding | MagicNumber | '16' is a magic number. | 42 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 42 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 42 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 42 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 44 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 45 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 46 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 46 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 46 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 46 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 48 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 49 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 50 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 50 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 50 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 50 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 53 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 53 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 53 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 53 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 53 | |
| design | DesignForExtension | Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 56 | |
| blocks | LeftCurly | '{' should have line break after. | 56 | |
| design | DesignForExtension | Method 'getSales' is not designed for extension - needs to be abstract, final or empty. | 58 | |
| blocks | LeftCurly | '{' should have line break after. | 58 | |
| design | DesignForExtension | Method 'setSales' is not designed for extension - needs to be abstract, final or empty. | 59 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 59 | |
| misc | FinalParameters | Parameter sales should be final. | 59 | |
| coding | HiddenField | 'sales' hides a field. | 59 | |
| design | DesignForExtension | Method 'addSale' is not designed for extension - needs to be abstract, final or empty. | 63 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 63 | |
| misc | FinalParameters | Parameter sale should be final. | 63 | |
| blocks | LeftCurly | '{' should have line break after. | 66 | |
| blocks | RightCurly | '}' should have line break before. | 66 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 71 | |
| design | DesignForExtension | Method 'getHireDate' is not designed for extension - needs to be abstract, final or empty. | 72 | |
| blocks | LeftCurly | '{' should have line break after. | 72 | |
| design | DesignForExtension | Method 'setHireDate' is not designed for extension - needs to be abstract, final or empty. | 73 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 73 | |
| misc | FinalParameters | Parameter hireDate should be final. | 73 | |
| coding | HiddenField | 'hireDate' hides a field. | 73 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 77 | |
| design | DesignForExtension | Method 'getTermDate' is not designed for extension - needs to be abstract, final or empty. | 78 | |
| blocks | LeftCurly | '{' should have line break after. | 78 | |
| design | DesignForExtension | Method 'setTermDate' is not designed for extension - needs to be abstract, final or empty. | 79 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 79 | |
| misc | FinalParameters | Parameter termDate should be final. | 79 | |
| coding | HiddenField | 'termDate' hides a field. | 79 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 82 | |
| design | DesignForExtension | Method 'getFirstName' is not designed for extension - needs to be abstract, final or empty. | 84 | |
| blocks | LeftCurly | '{' should have line break after. | 84 | |
| design | DesignForExtension | Method 'setFirstName' is not designed for extension - needs to be abstract, final or empty. | 85 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 85 | |
| misc | FinalParameters | Parameter firstName should be final. | 85 | |
| coding | HiddenField | 'firstName' hides a field. | 85 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 88 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 89 | |
| design | DesignForExtension | Method 'getLastName' is not designed for extension - needs to be abstract, final or empty. | 90 | |
| blocks | LeftCurly | '{' should have line break after. | 90 | |
| design | DesignForExtension | Method 'setLastName' is not designed for extension - needs to be abstract, final or empty. | 91 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 91 | |
| misc | FinalParameters | Parameter lastName should be final. | 91 | |
| coding | HiddenField | 'lastName' hides a field. | 91 | |
| design | DesignForExtension | Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 96 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 96 | |
| whitespace | WhitespaceAround | 'for' is not followed by whitespace. | 103 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocPackage | Missing package-info.java file. | ||
| javadoc | JavadocType | Missing a Javadoc comment. | 9 | |
| naming | TypeName | Name 'Clerk_' must match pattern '^[A-Z][a-zA-Z0-9]*$'. | 11 | |
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 13 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 13 | |
| design | VisibilityModifier | Variable 'firstName' must be private and have accessor methods. | 13 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 14 | |
| design | VisibilityModifier | Variable 'lastName' must be private and have accessor methods. | 14 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 15 | |
| design | VisibilityModifier | Variable 'hireDate' must be private and have accessor methods. | 15 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 16 | |
| design | VisibilityModifier | Variable 'id' must be private and have accessor methods. | 16 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 17 | |
| design | VisibilityModifier | Variable 'termDate' must be private and have accessor methods. | 17 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 18 | |
| design | VisibilityModifier | Variable 'sales' must be private and have accessor methods. | 18 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.persistence.*. | 3 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 5 | |
| javadoc | JavadocType | Missing a Javadoc comment. | 5 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 6 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 6 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 8 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 8 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 9 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 9 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 9 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 11 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 11 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 12 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 12 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 12 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 17 | |
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 17 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 23 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 23 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 24 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 24 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 24 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 26 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 27 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 27 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 27 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 27 | |
| coding | MagicNumber | '16' is a magic number. | 27 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 27 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 27 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 27 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 29 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 30 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 30 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 30 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 30 | |
| coding | MagicNumber | '16' is a magic number. | 30 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 30 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 30 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 30 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 32 | |
| design | DesignForExtension | Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 33 | |
| blocks | LeftCurly | '{' should have line break after. | 33 | |
| design | DesignForExtension | Method 'getFirstName' is not designed for extension - needs to be abstract, final or empty. | 35 | |
| blocks | LeftCurly | '{' should have line break after. | 35 | |
| design | DesignForExtension | Method 'setFirstName' is not designed for extension - needs to be abstract, final or empty. | 36 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 36 | |
| misc | FinalParameters | Parameter firstName should be final. | 36 | |
| coding | HiddenField | 'firstName' hides a field. | 36 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 40 | |
| design | DesignForExtension | Method 'getLastName' is not designed for extension - needs to be abstract, final or empty. | 41 | |
| blocks | LeftCurly | '{' should have line break after. | 41 | |
| design | DesignForExtension | Method 'setLastName' is not designed for extension - needs to be abstract, final or empty. | 42 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 42 | |
| misc | FinalParameters | Parameter lastName should be final. | 42 | |
| coding | HiddenField | 'lastName' hides a field. | 42 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 46 | |
| design | DesignForExtension | Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 47 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 47 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocType | Missing a Javadoc comment. | 7 | |
| naming | TypeName | Name 'Customer_' must match pattern '^[A-Z][a-zA-Z0-9]*$'. | 9 | |
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 11 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 11 | |
| design | VisibilityModifier | Variable 'firstName' must be private and have accessor methods. | 11 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 12 | |
| design | VisibilityModifier | Variable 'lastName' must be private and have accessor methods. | 12 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 13 | |
| design | VisibilityModifier | Variable 'id' must be private and have accessor methods. | 13 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocType | Missing a Javadoc comment. | 12 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 13 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 14 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 15 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 16 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 17 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 18 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 19 | |
| misc | FinalParameters | Parameter saleId should be final. | 19 | |
| coding | HiddenField | 'saleId' hides a field. | 19 | |
| misc | FinalParameters | Parameter customerId should be final. | 19 | |
| coding | HiddenField | 'customerId' hides a field. | 19 | |
| misc | FinalParameters | Parameter date should be final. | 19 | |
| coding | HiddenField | 'date' hides a field. | 19 | |
| misc | FinalParameters | Parameter amount should be final. | 19 | |
| coding | HiddenField | 'amount' hides a field. | 19 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 22 | |
| misc | FinalParameters | Parameter saleId should be final. | 22 | |
| coding | HiddenField | 'saleId' hides a field. | 22 | |
| misc | FinalParameters | Parameter customerId should be final. | 22 | |
| coding | HiddenField | 'customerId' hides a field. | 22 | |
| misc | FinalParameters | Parameter date should be final. | 22 | |
| coding | HiddenField | 'date' hides a field. | 22 | |
| misc | FinalParameters | Parameter amount should be final. | 22 | |
| coding | HiddenField | 'amount' hides a field. | 22 | |
| design | DesignForExtension | Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 28 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 28 | |
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 29 | |
| whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 34 | |
| whitespace | WhitespaceAround | '==' is not followed by whitespace. | 34 | |
| coding | AvoidInlineConditionals | Avoid inline conditionals. | 34 | |
| design | DesignForExtension | Method 'getAmount' is not designed for extension - needs to be abstract, final or empty. | 38 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 38 | |
| design | DesignForExtension | Method 'getCustomerId' is not designed for extension - needs to be abstract, final or empty. | 41 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 41 | |
| design | DesignForExtension | Method 'getDate' is not designed for extension - needs to be abstract, final or empty. | 44 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 44 | |
| design | DesignForExtension | Method 'getSaleId' is not designed for extension - needs to be abstract, final or empty. | 47 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 47 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocPackage | Missing package-info.java file. | ||
| imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.persistence.*. | 13 | |
| javadoc | JavadocType | Missing a Javadoc comment. | 15 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 16 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 16 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 18 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 18 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 19 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 19 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 22 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 25 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 25 | |
| coding | MagicNumber | '5' is a magic number. | 25 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 25 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 25 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 25 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 27 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 28 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 35 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 35 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 35 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 36 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 36 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 39 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 40 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 40 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 41 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 41 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 41 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 41 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 42 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 42 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 42 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 42 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 45 | |
| design | DesignForExtension | Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 46 | |
| blocks | LeftCurly | '{' should have line break after. | 46 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 47 | |
| design | DesignForExtension | Method 'getClerks' is not designed for extension - needs to be abstract, final or empty. | 48 | |
| blocks | LeftCurly | '{' should have line break after. | 48 | |
| design | DesignForExtension | Method 'setClerks' is not designed for extension - needs to be abstract, final or empty. | 49 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 49 | |
| misc | FinalParameters | Parameter clerks should be final. | 49 | |
| coding | HiddenField | 'clerks' hides a field. | 49 | |
| design | DesignForExtension | Method 'addClerk' is not designed for extension - needs to be abstract, final or empty. | 53 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 53 | |
| misc | FinalParameters | Parameter clerk should be final. | 53 | |
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 54 | |
| whitespace | WhitespaceAround | '!=' is not preceded with whitespace. | 54 | |
| whitespace | WhitespaceAround | '!=' is not followed by whitespace. | 54 | |
| blocks | LeftCurly | '{' should have line break after. | 56 | |
| blocks | RightCurly | '}' should have line break before. | 56 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 61 | |
| design | DesignForExtension | Method 'getStore' is not designed for extension - needs to be abstract, final or empty. | 62 | |
| blocks | LeftCurly | '{' should have line break after. | 62 | |
| design | DesignForExtension | Method 'setStore' is not designed for extension - needs to be abstract, final or empty. | 63 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 63 | |
| misc | FinalParameters | Parameter store should be final. | 63 | |
| coding | HiddenField | 'store' hides a field. | 63 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 66 | |
| design | DesignForExtension | Method 'getAmount' is not designed for extension - needs to be abstract, final or empty. | 68 | |
| blocks | LeftCurly | '{' should have line break after. | 68 | |
| design | DesignForExtension | Method 'setAmount' is not designed for extension - needs to be abstract, final or empty. | 69 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 69 | |
| misc | FinalParameters | Parameter amount should be final. | 69 | |
| coding | HiddenField | 'amount' hides a field. | 69 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 73 | |
| design | DesignForExtension | Method 'getBuyerId' is not designed for extension - needs to be abstract, final or empty. | 74 | |
| blocks | LeftCurly | '{' should have line break after. | 74 | |
| design | DesignForExtension | Method 'setBuyerId' is not designed for extension - needs to be abstract, final or empty. | 75 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 75 | |
| misc | FinalParameters | Parameter buyerId should be final. | 75 | |
| coding | HiddenField | 'buyerId' hides a field. | 75 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 79 | |
| design | DesignForExtension | Method 'getDate' is not designed for extension - needs to be abstract, final or empty. | 80 | |
| blocks | LeftCurly | '{' should have line break after. | 80 | |
| design | DesignForExtension | Method 'setDate' is not designed for extension - needs to be abstract, final or empty. | 81 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 81 | |
| misc | FinalParameters | Parameter date should be final. | 81 | |
| coding | HiddenField | 'date' hides a field. | 81 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 85 | |
| design | DesignForExtension | Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 86 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 86 | |
| whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 90 | |
| whitespace | WhitespaceAround | '==' is not followed by whitespace. | 90 | |
| coding | AvoidInlineConditionals | Avoid inline conditionals. | 90 | |
| whitespace | WhitespaceAround | 'for' is not followed by whitespace. | 94 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 96 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocType | Missing a Javadoc comment. | 10 | |
| naming | TypeName | Name 'Sale_' must match pattern '^[A-Z][a-zA-Z0-9]*$'. | 12 | |
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 14 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 14 | |
| design | VisibilityModifier | Variable 'date' must be private and have accessor methods. | 14 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 15 | |
| design | VisibilityModifier | Variable 'amount' must be private and have accessor methods. | 15 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 16 | |
| design | VisibilityModifier | Variable 'id' must be private and have accessor methods. | 16 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 17 | |
| design | VisibilityModifier | Variable 'store' must be private and have accessor methods. | 17 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 18 | |
| design | VisibilityModifier | Variable 'buyerId' must be private and have accessor methods. | 18 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 19 | |
| design | VisibilityModifier | Variable 'clerks' must be private and have accessor methods. | 19 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | AvoidStarImport | Using the '.*' form of import should be avoided - javax.persistence.*. | 7 | |
| javadoc | JavadocType | Missing a Javadoc comment. | 9 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 9 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 9 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 11 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 11 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 12 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 12 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 14 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 15 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 15 | |
| coding | MagicNumber | '20' is a magic number. | 15 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 15 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 15 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 15 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 18 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 18 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 18 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 18 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 19 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 19 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 19 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 20 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 20 | |
| design | DesignForExtension | Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 23 | |
| blocks | LeftCurly | '{' should have line break after. | 23 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 24 | |
| design | DesignForExtension | Method 'getSales' is not designed for extension - needs to be abstract, final or empty. | 25 | |
| blocks | LeftCurly | '{' should have line break after. | 25 | |
| design | DesignForExtension | Method 'setSales' is not designed for extension - needs to be abstract, final or empty. | 26 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 26 | |
| misc | FinalParameters | Parameter sales should be final. | 26 | |
| coding | HiddenField | 'sales' hides a field. | 26 | |
| design | DesignForExtension | Method 'addSale' is not designed for extension - needs to be abstract, final or empty. | 30 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 30 | |
| misc | FinalParameters | Parameter sale should be final. | 30 | |
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 31 | |
| blocks | LeftCurly | '{' should have line break after. | 33 | |
| blocks | RightCurly | '}' should have line break before. | 33 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 38 | |
| design | DesignForExtension | Method 'getName' is not designed for extension - needs to be abstract, final or empty. | 39 | |
| blocks | LeftCurly | '{' should have line break after. | 39 | |
| design | DesignForExtension | Method 'setName' is not designed for extension - needs to be abstract, final or empty. | 40 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 40 | |
| misc | FinalParameters | Parameter name should be final. | 40 | |
| coding | HiddenField | 'name' hides a field. | 40 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 44 | |
| design | DesignForExtension | Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 45 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 45 | |
| whitespace | WhitespaceAround | 'for' is not followed by whitespace. | 49 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocType | Missing a Javadoc comment. | 8 | |
| naming | TypeName | Name 'Store_' must match pattern '^[A-Z][a-zA-Z0-9]*$'. | 10 | |
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 12 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 12 | |
| design | VisibilityModifier | Variable 'name' must be private and have accessor methods. | 12 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 13 | |
| design | VisibilityModifier | Variable 'id' must be private and have accessor methods. | 13 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 14 | |
| design | VisibilityModifier | Variable 'sales' must be private and have accessor methods. | 14 |