The following document contains the results of Checkstyle 6.2 with sun_checks.xml ruleset. 
| Category | Rule | Violations | Severity |
|---|---|---|---|
| coding | HiddenField | 20 | |
| MagicNumber | 2 | ||
| design | DesignForExtension | 31 | |
| javadoc | JavadocMethod | 46 | |
| JavadocPackage | 3 | ||
| JavadocStyle | 1 | ||
| JavadocType | 2 | ||
| JavadocVariable | 18 | ||
| misc | FinalParameters | 30 | |
| naming | ConstantName | 1 | |
| regexp | RegexpSingleline
|
24 | |
| sizes | LineLength | 6 | |
| whitespace | FileTabCharacter | 7 | |
| WhitespaceAfter | 2 | ||
| WhitespaceAround | 59 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocPackage | Missing package-info.java file. | ||
| regexp | RegexpSingleline | Line has trailing spaces. | 8 | |
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 12 | |
| javadoc | JavadocMethod | Expected an @return tag. | 17 | |
| javadoc | JavadocMethod | Expected @param tag for 'offset'. | 17 | |
| javadoc | JavadocMethod | Expected @param tag for 'limit'. | 17 | |
| javadoc | JavadocMethod | Expected an @return tag. | 25 | |
| javadoc | JavadocMethod | Expected @param tag for 'id'. | 25 | |
| javadoc | JavadocMethod | Expected @param tag for 'validEmail'. | 25 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 9 | |
| javadoc | JavadocMethod | Expected an @return tag. | 15 | |
| javadoc | JavadocMethod | Expected @param tag for 'email'. | 15 | |
| javadoc | JavadocMethod | Expected @param tag for 'firstName'. | 15 | |
| javadoc | JavadocMethod | Expected @param tag for 'lastName'. | 15 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 20 | |
| javadoc | JavadocMethod | Expected an @return tag. | 25 | |
| javadoc | JavadocMethod | Expected @param tag for 'email'. | 25 | |
| javadoc | JavadocMethod | Expected @param tag for 'password'. | 25 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocPackage | Missing package-info.java file. | ||
| javadoc | JavadocType | Missing a Javadoc comment. | 16 | |
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 17 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 17 | |
| naming | ConstantName | Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 17 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 18 | |
| design | DesignForExtension | Method 'setEntityManager' is not designed for extension - needs to be abstract, final or empty. | 20 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 20 | |
| misc | FinalParameters | Parameter entityManager should be final. | 20 | |
| design | DesignForExtension | Method 'getProducts' is not designed for extension - needs to be abstract, final or empty. | 24 | |
| misc | FinalParameters | Parameter offset should be final. | 26 | |
| misc | FinalParameters | Parameter limit should be final. | 26 | |
| design | DesignForExtension | Method 'addToCart' is not designed for extension - needs to be abstract, final or empty. | 37 | |
| misc | FinalParameters | Parameter id should be final. | 38 | |
| misc | FinalParameters | Parameter email should be final. | 38 | |
| whitespace | WhitespaceAround | '-' is not preceded with whitespace. | 44 | |
| whitespace | WhitespaceAround | '-' is not followed by whitespace. | 44 | |
| whitespace | WhitespaceAround | '-' is not preceded with whitespace. | 48 | |
| whitespace | WhitespaceAround | '-' is not followed by whitespace. | 48 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 64 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 20 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 20 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 21 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 22 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 22 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 22 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 23 | |
| design | DesignForExtension | Method 'setEntityManager' is not designed for extension - needs to be abstract, final or empty. | 24 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 24 | |
| misc | FinalParameters | Parameter em should be final. | 24 | |
| coding | HiddenField | 'em' hides a field. | 24 | |
| design | DesignForExtension | Method 'createAccount' is not designed for extension - needs to be abstract, final or empty. | 28 | |
| sizes | LineLength | Line is longer than 80 characters (found 87). | 29 | |
| misc | FinalParameters | Parameter email should be final. | 29 | |
| misc | FinalParameters | Parameter firstName should be final. | 29 | |
| misc | FinalParameters | Parameter lastName should be final. | 29 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 30 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 30 | |
| whitespace | WhitespaceAround | '==' is not preceded with whitespace. | 33 | |
| whitespace | WhitespaceAround | '==' is not followed by whitespace. | 33 | |
| sizes | LineLength | Line is longer than 80 characters (found 82). | 34 | |
| sizes | LineLength | Line is longer than 80 characters (found 85). | 41 | |
| design | DesignForExtension | Method 'checkout' is not designed for extension - needs to be abstract, final or empty. | 44 | |
| misc | FinalParameters | Parameter email should be final. | 45 | |
| misc | FinalParameters | Parameter password should be final. | 45 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 51 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 57 | |
| sizes | LineLength | Line is longer than 80 characters (found 108). | 62 | |
| whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 62 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 64 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 68 | |
| coding | MagicNumber | '8' is a magic number. | 69 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 70 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 70 | |
| whitespace | WhitespaceAround | '<' is not preceded with whitespace. | 70 | |
| whitespace | WhitespaceAround | '<' is not followed by whitespace. | 70 | |
| whitespace | WhitespaceAfter | 'cast' is not followed by whitespace. | 71 | |
| coding | MagicNumber | '25' is a magic number. | 71 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocPackage | Missing package-info.java file. | ||
| javadoc | JavadocStyle | First sentence should end with a period. | 11 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 12 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 15 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 15 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 17 | |
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 17 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 17 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 17 | |
| sizes | LineLength | Line is longer than 80 characters (found 81). | 18 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 18 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 18 | |
| sizes | LineLength | Line is longer than 80 characters (found 83). | 21 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 21 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 21 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 21 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 22 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 23 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 25 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 26 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 26 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 26 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 26 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 26 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 28 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 29 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 29 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 29 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 31 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 32 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 34 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 35 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 35 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 35 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 38 | |
| whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 38 | |
| whitespace | WhitespaceAround | '{' is not followed by whitespace. | 38 | |
| whitespace | WhitespaceAround | '}' is not preceded with whitespace. | 38 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 39 | |
| misc | FinalParameters | Parameter email should be final. | 39 | |
| coding | HiddenField | 'email' hides a field. | 39 | |
| misc | FinalParameters | Parameter firstName should be final. | 39 | |
| coding | HiddenField | 'firstName' hides a field. | 39 | |
| misc | FinalParameters | Parameter lastName should be final. | 39 | |
| coding | HiddenField | 'lastName' hides a field. | 39 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 44 | |
| design | DesignForExtension | Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 45 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 45 | |
| design | DesignForExtension | Method 'setId' is not designed for extension - needs to be abstract, final or empty. | 48 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 48 | |
| misc | FinalParameters | Parameter id should be final. | 48 | |
| coding | HiddenField | 'id' hides a field. | 48 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 51 | |
| design | DesignForExtension | Method 'getEmail' is not designed for extension - needs to be abstract, final or empty. | 52 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 52 | |
| design | DesignForExtension | Method 'setEmail' is not designed for extension - needs to be abstract, final or empty. | 55 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 55 | |
| misc | FinalParameters | Parameter email should be final. | 55 | |
| coding | HiddenField | 'email' hides a field. | 55 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 58 | |
| design | DesignForExtension | Method 'getPassword' is not designed for extension - needs to be abstract, final or empty. | 59 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 59 | |
| design | DesignForExtension | Method 'setPassword' is not designed for extension - needs to be abstract, final or empty. | 62 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 62 | |
| misc | FinalParameters | Parameter password should be final. | 62 | |
| coding | HiddenField | 'password' hides a field. | 62 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 65 | |
| design | DesignForExtension | Method 'getFirstName' is not designed for extension - needs to be abstract, final or empty. | 66 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 66 | |
| design | DesignForExtension | Method 'setFirstName' is not designed for extension - needs to be abstract, final or empty. | 69 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 69 | |
| misc | FinalParameters | Parameter firstName should be final. | 69 | |
| coding | HiddenField | 'firstName' hides a field. | 69 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 72 | |
| design | DesignForExtension | Method 'getLastName' is not designed for extension - needs to be abstract, final or empty. | 73 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 73 | |
| design | DesignForExtension | Method 'setLastName' is not designed for extension - needs to be abstract, final or empty. | 76 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 76 | |
| misc | FinalParameters | Parameter lastName should be final. | 76 | |
| coding | HiddenField | 'lastName' hides a field. | 76 | |
| design | DesignForExtension | Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 80 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 89 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 90 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 17 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 17 | |
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 19 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 19 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 21 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 22 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 23 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 23 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 25 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 26 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 29 | |
| whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 29 | |
| whitespace | WhitespaceAround | '{' is not followed by whitespace. | 29 | |
| whitespace | WhitespaceAround | '}' is not preceded with whitespace. | 29 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 30 | |
| misc | FinalParameters | Parameter account should be final. | 30 | |
| coding | HiddenField | 'account' hides a field. | 30 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 31 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 31 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 32 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 32 | |
| design | DesignForExtension | Method 'getEmail' is not designed for extension - needs to be abstract, final or empty. | 35 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 35 | |
| design | DesignForExtension | Method 'setEmail' is not designed for extension - needs to be abstract, final or empty. | 38 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 38 | |
| misc | FinalParameters | Parameter email should be final. | 38 | |
| coding | HiddenField | 'email' hides a field. | 38 | |
| design | DesignForExtension | Method 'getAccount' is not designed for extension - needs to be abstract, final or empty. | 42 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 42 | |
| design | DesignForExtension | Method 'setAccount' is not designed for extension - needs to be abstract, final or empty. | 46 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 46 | |
| misc | FinalParameters | Parameter account should be final. | 46 | |
| coding | HiddenField | 'account' hides a field. | 46 | |
| design | DesignForExtension | Method 'getProducts' is not designed for extension - needs to be abstract, final or empty. | 50 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 50 | |
| design | DesignForExtension | Method 'setProducts' is not designed for extension - needs to be abstract, final or empty. | 54 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 54 | |
| misc | FinalParameters | Parameter products should be final. | 54 | |
| coding | HiddenField | 'products' hides a field. | 54 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocType | Missing a Javadoc comment. | 9 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 10 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 10 | |
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 12 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 12 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 13 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 14 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 14 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 14 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 16 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 16 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 16 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 18 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 18 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 18 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 21 | |
| whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 21 | |
| whitespace | WhitespaceAround | '{' is not followed by whitespace. | 21 | |
| whitespace | WhitespaceAround | '}' is not preceded with whitespace. | 21 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 22 | |
| misc | FinalParameters | Parameter name should be final. | 22 | |
| coding | HiddenField | 'name' hides a field. | 22 | |
| misc | FinalParameters | Parameter price should be final. | 22 | |
| coding | HiddenField | 'price' hides a field. | 22 | |
| misc | FinalParameters | Parameter count should be final. | 22 | |
| coding | HiddenField | 'count' hides a field. | 22 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 25 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 25 | |
| design | DesignForExtension | Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 27 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 27 | |
| design | DesignForExtension | Method 'setId' is not designed for extension - needs to be abstract, final or empty. | 30 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 30 | |
| misc | FinalParameters | Parameter id should be final. | 30 | |
| coding | HiddenField | 'id' hides a field. | 30 | |
| design | DesignForExtension | Method 'getName' is not designed for extension - needs to be abstract, final or empty. | 33 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 33 | |
| design | DesignForExtension | Method 'setName' is not designed for extension - needs to be abstract, final or empty. | 36 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 36 | |
| misc | FinalParameters | Parameter name should be final. | 36 | |
| coding | HiddenField | 'name' hides a field. | 36 | |
| design | DesignForExtension | Method 'getPrice' is not designed for extension - needs to be abstract, final or empty. | 39 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 39 | |
| design | DesignForExtension | Method 'setPrice' is not designed for extension - needs to be abstract, final or empty. | 42 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 42 | |
| misc | FinalParameters | Parameter price should be final. | 42 | |
| coding | HiddenField | 'price' hides a field. | 42 | |
| design | DesignForExtension | Method 'getCount' is not designed for extension - needs to be abstract, final or empty. | 45 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 45 | |
| design | DesignForExtension | Method 'setCount' is not designed for extension - needs to be abstract, final or empty. | 48 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 48 | |
| misc | FinalParameters | Parameter count should be final. | 48 | |
| coding | HiddenField | 'count' hides a field. | 48 |