Checkstyle Results

The following document contains the results of Checkstyle 6.2 with sun_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
8 0 0 303

Files

File  I  W  E
info/ejava/examples/ejb/ejbjpa/bl/HotelMgmt.java 0 0 7
info/ejava/examples/ejb/ejbjpa/bl/HotelMgmtImpl.java 0 0 42
info/ejava/examples/ejb/ejbjpa/bl/RoomUnavailableExcepton.java 0 0 8
info/ejava/examples/ejb/ejbjpa/bo/Floor.java 0 0 64
info/ejava/examples/ejb/ejbjpa/bo/Guest.java 0 0 37
info/ejava/examples/ejb/ejbjpa/bo/Room.java 0 0 49
info/ejava/examples/ejb/ejbjpa/dao/HotelDAO.java 0 0 16
info/ejava/examples/ejb/ejbjpa/dao/JPAHotelDAO.java 0 0 80

Rules

Category Rule Violations Severity
blocks LeftCurly 8  Error
RightCurly 1  Error
coding AvoidInlineConditionals 2  Error
HiddenField 10  Error
MagicNumber 5  Error
design DesignForExtension 34  Error
VisibilityModifier 2  Error
javadoc JavadocMethod 34  Error
JavadocPackage 3  Error
JavadocType 8  Error
JavadocVariable 12  Error
misc FinalParameters 44  Error
regexp RegexpSingleline
  • format: "\s+$"
  • maximum: "0"
  • message: "Line has trailing spaces."
  • minimum: "0"
 39  Error
sizes LineLength 7  Error
whitespace WhitespaceAround 94  Error

Details

info/ejava/examples/ejb/ejbjpa/bl/HotelMgmt.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 9
 Error javadoc JavadocMethod Missing a Javadoc comment. 10
 Error javadoc JavadocMethod Missing a Javadoc comment. 11
 Error javadoc JavadocMethod Missing a Javadoc comment. 12
 Error javadoc JavadocMethod Missing a Javadoc comment. 13
 Error javadoc JavadocMethod Missing a Javadoc comment. 14
 Error javadoc JavadocMethod Missing a Javadoc comment. 15

info/ejava/examples/ejb/ejbjpa/bl/HotelMgmtImpl.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 10
 Error javadoc JavadocVariable Missing a Javadoc comment. 11
 Error regexp RegexpSingleline Line has trailing spaces. 12
 Error design DesignForExtension Method 'setHotelDao' is not designed for extension - needs to be abstract, final or empty. 13
 Error javadoc JavadocMethod Missing a Javadoc comment. 13
 Error misc FinalParameters Parameter dao should be final. 13
 Error coding HiddenField 'dao' hides a field. 13
 Error design DesignForExtension Method 'getRoom' is not designed for extension - needs to be abstract, final or empty. 17
 Error misc FinalParameters Parameter number should be final. 18
 Error design DesignForExtension Method 'getFloor' is not designed for extension - needs to be abstract, final or empty. 22
 Error misc FinalParameters Parameter level should be final. 23
 Error design DesignForExtension Method 'getFloors' is not designed for extension - needs to be abstract, final or empty. 27
 Error misc FinalParameters Parameter offset should be final. 28
 Error misc FinalParameters Parameter limit should be final. 28
 Error regexp RegexpSingleline Line has trailing spaces. 31
 Error design DesignForExtension Method 'getAvailableRooms' is not designed for extension - needs to be abstract, final or empty. 32
 Error misc FinalParameters Parameter level should be final. 33
 Error misc FinalParameters Parameter offset should be final. 33
 Error misc FinalParameters Parameter limit should be final. 33
 Error regexp RegexpSingleline Line has trailing spaces. 36
 Error design DesignForExtension Method 'checkIn' is not designed for extension - needs to be abstract, final or empty. 37
 Error sizes LineLength Line is longer than 80 characters (found 81). 38
 Error misc FinalParameters Parameter guest should be final. 38
 Error misc FinalParameters Parameter room should be final. 38
 Error whitespace WhitespaceAround '==' is not preceded with whitespace. 39
 Error whitespace WhitespaceAround '==' is not followed by whitespace. 39
 Error regexp RegexpSingleline Line has trailing spaces. 42
 Error whitespace WhitespaceAround '==' is not preceded with whitespace. 44
 Error whitespace WhitespaceAround '==' is not followed by whitespace. 44
 Error sizes LineLength Line is longer than 80 characters (found 107). 45
 Error regexp RegexpSingleline Line has trailing spaces. 47
 Error whitespace WhitespaceAround '!=' is not preceded with whitespace. 48
 Error whitespace WhitespaceAround '!=' is not followed by whitespace. 48
 Error sizes LineLength Line is longer than 80 characters (found 112). 49
 Error regexp RegexpSingleline Line has trailing spaces. 51
 Error regexp RegexpSingleline Line has trailing spaces. 56
 Error design DesignForExtension Method 'checkout' is not designed for extension - needs to be abstract, final or empty. 57
 Error misc FinalParameters Parameter guest should be final. 58
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 59
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 59
 Error whitespace WhitespaceAround '!=' is not preceded with whitespace. 60
 Error whitespace WhitespaceAround '!=' is not followed by whitespace. 60

info/ejava/examples/ejb/ejbjpa/bl/RoomUnavailableExcepton.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocType Missing a Javadoc comment. 3
 Error javadoc JavadocVariable Missing a Javadoc comment. 4
 Error javadoc JavadocMethod Missing a Javadoc comment. 6
 Error misc FinalParameters Parameter message should be final. 6
 Error misc FinalParameters Parameter cause should be final. 6
 Error javadoc JavadocMethod Missing a Javadoc comment. 10
 Error misc FinalParameters Parameter message should be final. 10

info/ejava/examples/ejb/ejbjpa/bo/Floor.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocType Missing a Javadoc comment. 18
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 19
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 19
 Error regexp RegexpSingleline Line has trailing spaces. 21
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 21
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 21
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 22
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 22
 Error regexp RegexpSingleline Line has trailing spaces. 23
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 23
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 23
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 24
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 24
 Error javadoc JavadocVariable Missing a Javadoc comment. 30
 Error javadoc JavadocVariable Missing a Javadoc comment. 32
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 33
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 33
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 33
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 33
 Error design VisibilityModifier Variable 'level' must be private and have accessor methods. 34
 Error regexp RegexpSingleline Line has trailing spaces. 35
 Error regexp RegexpSingleline Line has trailing spaces. 36
 Error javadoc JavadocVariable Missing a Javadoc comment. 36
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 36
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 36
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 37
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 37
 Error sizes LineLength Line is longer than 80 characters (found 82). 38
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 38
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 38
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 39
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 39
 Error design VisibilityModifier Variable 'rooms' must be private and have accessor methods. 41
 Error regexp RegexpSingleline Line has trailing spaces. 42
 Error javadoc JavadocMethod Missing a Javadoc comment. 43
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 43
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 43
 Error javadoc JavadocMethod Missing a Javadoc comment. 44
 Error misc FinalParameters Parameter level should be final. 44
 Error coding HiddenField 'level' hides a field. 44
 Error regexp RegexpSingleline Line has trailing spaces. 47
 Error design DesignForExtension Method 'getLevel' is not designed for extension - needs to be abstract, final or empty. 48
 Error blocks LeftCurly '{' should have line break after. 48
 Error design DesignForExtension Method 'getRooms' is not designed for extension - needs to be abstract, final or empty. 50
 Error blocks LeftCurly '{' should have line break after. 50
 Error design DesignForExtension Method 'setRooms' is not designed for extension - needs to be abstract, final or empty. 51
 Error javadoc JavadocMethod Missing a Javadoc comment. 51
 Error misc FinalParameters Parameter rooms should be final. 51
 Error coding HiddenField 'rooms' hides a field. 51
 Error design DesignForExtension Method 'withRoom' is not designed for extension - needs to be abstract, final or empty. 54
 Error javadoc JavadocMethod Missing a Javadoc comment. 54
 Error misc FinalParameters Parameter room should be final. 54
 Error whitespace WhitespaceAround '==' is not preceded with whitespace. 55
 Error whitespace WhitespaceAround '==' is not followed by whitespace. 55
 Error whitespace WhitespaceAround '!=' is not preceded with whitespace. 58
 Error whitespace WhitespaceAround '!=' is not followed by whitespace. 58
 Error design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 64
 Error whitespace WhitespaceAround '!=' is not preceded with whitespace. 69
 Error whitespace WhitespaceAround '!=' is not followed by whitespace. 69
 Error blocks LeftCurly '{' should have line break after. 69
 Error whitespace WhitespaceAround '}' is not followed by whitespace. 71
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 71
 Error blocks RightCurly '}' should be on a new line. 71

info/ejava/examples/ejb/ejbjpa/bo/Guest.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 11
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 12
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 12
 Error javadoc JavadocVariable Missing a Javadoc comment. 14
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 15
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 15
 Error regexp RegexpSingleline Line has trailing spaces. 17
 Error javadoc JavadocVariable Missing a Javadoc comment. 18
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 18
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 18
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 18
 Error coding MagicNumber '60' is a magic number. 18
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 18
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 18
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 18
 Error regexp RegexpSingleline Line has trailing spaces. 20
 Error javadoc JavadocMethod Missing a Javadoc comment. 21
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 21
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 21
 Error javadoc JavadocMethod Missing a Javadoc comment. 22
 Error misc FinalParameters Parameter id should be final. 22
 Error coding HiddenField 'id' hides a field. 22
 Error javadoc JavadocMethod Missing a Javadoc comment. 25
 Error misc FinalParameters Parameter name should be final. 25
 Error coding HiddenField 'name' hides a field. 25
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 26
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 26
 Error regexp RegexpSingleline Line has trailing spaces. 28
 Error design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 29
 Error blocks LeftCurly '{' should have line break after. 29
 Error design DesignForExtension Method 'getName' is not designed for extension - needs to be abstract, final or empty. 31
 Error blocks LeftCurly '{' should have line break after. 31
 Error design DesignForExtension Method 'setName' is not designed for extension - needs to be abstract, final or empty. 32
 Error javadoc JavadocMethod Missing a Javadoc comment. 32
 Error misc FinalParameters Parameter name should be final. 32
 Error coding HiddenField 'name' hides a field. 32
 Error design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 36

info/ejava/examples/ejb/ejbjpa/bo/Room.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 16
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 17
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 17
 Error regexp RegexpSingleline Line has trailing spaces. 19
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 19
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 19
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 20
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 20
 Error javadoc JavadocVariable Missing a Javadoc comment. 23
 Error javadoc JavadocVariable Missing a Javadoc comment. 25
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 26
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 26
 Error regexp RegexpSingleline Line has trailing spaces. 28
 Error javadoc JavadocVariable Missing a Javadoc comment. 29
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 29
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 29
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 29
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 29
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 30
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 30
 Error regexp RegexpSingleline Line has trailing spaces. 32
 Error javadoc JavadocVariable Missing a Javadoc comment. 33
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 33
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 33
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 33
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 33
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 34
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 34
 Error javadoc JavadocMethod Missing a Javadoc comment. 37
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 37
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 37
 Error javadoc JavadocMethod Missing a Javadoc comment. 38
 Error misc FinalParameters Parameter floor should be final. 38
 Error coding HiddenField 'floor' hides a field. 38
 Error misc FinalParameters Parameter number should be final. 38
 Error coding HiddenField 'number' hides a field. 38
 Error regexp RegexpSingleline Line has trailing spaces. 42
 Error design DesignForExtension Method 'getNumber' is not designed for extension - needs to be abstract, final or empty. 43
 Error blocks LeftCurly '{' should have line break after. 43
 Error design DesignForExtension Method 'getFloor' is not designed for extension - needs to be abstract, final or empty. 44
 Error blocks LeftCurly '{' should have line break after. 44
 Error design DesignForExtension Method 'getOccupant' is not designed for extension - needs to be abstract, final or empty. 46
 Error blocks LeftCurly '{' should have line break after. 46
 Error design DesignForExtension Method 'setOccupant' is not designed for extension - needs to be abstract, final or empty. 47
 Error javadoc JavadocMethod Missing a Javadoc comment. 47
 Error misc FinalParameters Parameter occupant should be final. 47
 Error coding HiddenField 'occupant' hides a field. 47
 Error regexp RegexpSingleline Line has trailing spaces. 50
 Error design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 51

info/ejava/examples/ejb/ejbjpa/dao/HotelDAO.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 9
 Error javadoc JavadocMethod Missing a Javadoc comment. 10
 Error javadoc JavadocMethod Missing a Javadoc comment. 11
 Error javadoc JavadocMethod Missing a Javadoc comment. 12
 Error regexp RegexpSingleline Line has trailing spaces. 13
 Error javadoc JavadocMethod Missing a Javadoc comment. 14
 Error javadoc JavadocMethod Missing a Javadoc comment. 15
 Error javadoc JavadocMethod Missing a Javadoc comment. 16
 Error javadoc JavadocMethod Missing a Javadoc comment. 17
 Error regexp RegexpSingleline Line has trailing spaces. 18
 Error javadoc JavadocMethod Missing a Javadoc comment. 19
 Error regexp RegexpSingleline Line has trailing spaces. 20
 Error javadoc JavadocMethod Missing a Javadoc comment. 21
 Error javadoc JavadocMethod Missing a Javadoc comment. 22
 Error regexp RegexpSingleline Line has trailing spaces. 23
 Error javadoc JavadocMethod Missing a Javadoc comment. 24

info/ejava/examples/ejb/ejbjpa/dao/JPAHotelDAO.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocType Missing a Javadoc comment. 18
 Error javadoc JavadocVariable Missing a Javadoc comment. 19
 Error regexp RegexpSingleline Line has trailing spaces. 20
 Error design DesignForExtension Method 'setEntityManager' is not designed for extension - needs to be abstract, final or empty. 21
 Error javadoc JavadocMethod Missing a Javadoc comment. 21
 Error misc FinalParameters Parameter em should be final. 21
 Error coding HiddenField 'em' hides a field. 21
 Error regexp RegexpSingleline Line has trailing spaces. 24
 Error sizes LineLength Line is longer than 80 characters (found 86). 25
 Error javadoc JavadocMethod Missing a Javadoc comment. 25
 Error misc FinalParameters Parameter query should be final. 25
 Error misc FinalParameters Parameter offset should be final. 25
 Error misc FinalParameters Parameter limit should be final. 25
 Error regexp RegexpSingleline Line has trailing spaces. 34
 Error design DesignForExtension Method 'populate' is not designed for extension - needs to be abstract, final or empty. 35
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 37
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 37
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 38
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 38
 Error whitespace WhitespaceAround '<' is not preceded with whitespace. 38
 Error coding MagicNumber '3' is a magic number. 38
 Error whitespace WhitespaceAround '<' is not followed by whitespace. 38
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 40
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 40
 Error whitespace WhitespaceAround '<' is not preceded with whitespace. 40
 Error coding MagicNumber '3' is a magic number. 40
 Error whitespace WhitespaceAround '<' is not followed by whitespace. 40
 Error whitespace WhitespaceAround '*' is not preceded with whitespace. 41
 Error whitespace WhitespaceAround '*' is not followed by whitespace. 41
 Error coding MagicNumber '100' is a magic number. 41
 Error whitespace WhitespaceAround '==' is not preceded with whitespace. 43
 Error whitespace WhitespaceAround '==' is not followed by whitespace. 43
 Error regexp RegexpSingleline Line has trailing spaces. 52
 Error design DesignForExtension Method 'clearAll' is not designed for extension - needs to be abstract, final or empty. 53
 Error regexp RegexpSingleline Line has trailing spaces. 60
 Error design DesignForExtension Method 'addFloor' is not designed for extension - needs to be abstract, final or empty. 61
 Error misc FinalParameters Parameter floor should be final. 62
 Error design DesignForExtension Method 'getFloor' is not designed for extension - needs to be abstract, final or empty. 66
 Error misc FinalParameters Parameter level should be final. 67
 Error regexp RegexpSingleline Line has trailing spaces. 70
 Error design DesignForExtension Method 'fetchFloor' is not designed for extension - needs to be abstract, final or empty. 71
 Error misc FinalParameters Parameter level should be final. 72
 Error coding AvoidInlineConditionals Avoid inline conditionals. 77
 Error design DesignForExtension Method 'getFloors' is not designed for extension - needs to be abstract, final or empty. 80
 Error misc FinalParameters Parameter offset should be final. 81
 Error misc FinalParameters Parameter limit should be final. 81
 Error regexp RegexpSingleline Line has trailing spaces. 82
 Error design DesignForExtension Method 'getRoom' is not designed for extension - needs to be abstract, final or empty. 88
 Error misc FinalParameters Parameter number should be final. 89
 Error sizes LineLength Line is longer than 80 characters (found 93). 93
 Error design DesignForExtension Method 'getAvailableRoomsQuery' is not designed for extension - needs to be abstract, final or empty. 93
 Error javadoc JavadocMethod Missing a Javadoc comment. 93
 Error misc FinalParameters Parameter level should be final. 93
 Error misc FinalParameters Parameter offset should be final. 93
 Error misc FinalParameters Parameter limit should be final. 93
 Error regexp RegexpSingleline Line has trailing spaces. 97
 Error whitespace WhitespaceAround '!=' is not preceded with whitespace. 101
 Error whitespace WhitespaceAround '!=' is not followed by whitespace. 101
 Error regexp RegexpSingleline Line has trailing spaces. 104
 Error design DesignForExtension Method 'getAvailableRooms' is not designed for extension - needs to be abstract, final or empty. 110
 Error misc FinalParameters Parameter level should be final. 111
 Error misc FinalParameters Parameter offset should be final. 111
 Error misc FinalParameters Parameter limit should be final. 111
 Error regexp RegexpSingleline Line has trailing spaces. 115
 Error design DesignForExtension Method 'getAvailableRoomsForUpdate' is not designed for extension - needs to be abstract, final or empty. 116
 Error sizes LineLength Line is longer than 80 characters (found 88). 117
 Error misc FinalParameters Parameter level should be final. 117
 Error misc FinalParameters Parameter offset should be final. 117
 Error misc FinalParameters Parameter limit should be final. 117
 Error coding MagicNumber '5000' is a magic number. 120
 Error regexp RegexpSingleline Line has trailing spaces. 123
 Error regexp RegexpSingleline Line has trailing spaces. 124
 Error design DesignForExtension Method 'findRoomByGuest' is not designed for extension - needs to be abstract, final or empty. 125
 Error misc FinalParameters Parameter guest should be final. 126
 Error regexp RegexpSingleline Line has trailing spaces. 127
 Error coding AvoidInlineConditionals Avoid inline conditionals. 131
 Error regexp RegexpSingleline Line has trailing spaces. 133
 Error design DesignForExtension Method 'addGuest' is not designed for extension - needs to be abstract, final or empty. 134
 Error misc FinalParameters Parameter guest should be final. 135