The following document contains the results of Checkstyle 6.18 with sun_checks.xml ruleset.
Category | Rule | Violations | Severity |
---|---|---|---|
blocks | LeftCurly | 11 | ![]() |
coding | HiddenField | 11 | ![]() |
MagicNumber | 2 | ![]() | |
design | DesignForExtension | 31 | ![]() |
imports | UnusedImports
|
1 | ![]() |
javadoc | JavadocMethod | 32 | ![]() |
JavadocPackage | 2 | ![]() | |
JavadocStyle | 1 | ![]() | |
JavadocType | 3 | ![]() | |
JavadocVariable | 11 | ![]() | |
misc | FinalParameters | 36 | ![]() |
NewlineAtEndOfFile | 1 | ![]() | |
regexp | RegexpSingleline
|
34 | ![]() |
sizes | LineLength | 10 | ![]() |
whitespace | FileTabCharacter | 4 | ![]() |
OperatorWrap | 2 | ![]() | |
WhitespaceAfter | 1 | ![]() | |
WhitespaceAround | 17 | ![]() |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocType | Missing a Javadoc comment. | 6 |
![]() |
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 7 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 7 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 8 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
![]() |
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 10 |
![]() |
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 10 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 11 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 12 |
![]() |
whitespace | WhitespaceAround | '{' is not followed by whitespace. | 12 |
![]() |
whitespace | WhitespaceAround | '}' is not preceded with whitespace. | 12 |
![]() |
misc | FinalParameters | Parameter id should be final. | 13 |
![]() |
coding | HiddenField | 'id' hides a field. | 13 |
![]() |
blocks | LeftCurly | '{' at column 24 should have line break after. | 13 |
![]() |
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 13 |
![]() |
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 13 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 14 |
![]() |
design | DesignForExtension | Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 15 |
![]() |
blocks | LeftCurly | '{' at column 21 should have line break after. | 15 |
![]() |
design | DesignForExtension | Method 'getFirstName' is not designed for extension - needs to be abstract, final or empty. | 17 |
![]() |
blocks | LeftCurly | '{' at column 31 should have line break after. | 17 |
![]() |
design | DesignForExtension | Method 'setFirstName' is not designed for extension - needs to be abstract, final or empty. | 18 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 18 |
![]() |
misc | FinalParameters | Parameter firstName should be final. | 18 |
![]() |
coding | HiddenField | 'firstName' hides a field. | 18 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 21 |
![]() |
design | DesignForExtension | Method 'getLastName' is not designed for extension - needs to be abstract, final or empty. | 22 |
![]() |
blocks | LeftCurly | '{' at column 30 should have line break after. | 22 |
![]() |
design | DesignForExtension | Method 'setLastName' is not designed for extension - needs to be abstract, final or empty. | 23 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 23 |
![]() |
misc | FinalParameters | Parameter lastName should be final. | 23 |
![]() |
coding | HiddenField | 'lastName' hides a field. | 23 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 26 |
![]() |
design | DesignForExtension | Method 'getBooks' is not designed for extension - needs to be abstract, final or empty. | 27 |
![]() |
blocks | LeftCurly | '{' at column 31 should have line break after. | 27 |
![]() |
design | DesignForExtension | Method 'setBooks' is not designed for extension - needs to be abstract, final or empty. | 28 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 28 |
![]() |
misc | FinalParameters | Parameter books should be final. | 28 |
![]() |
coding | HiddenField | 'books' hides a field. | 28 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocPackage | Missing package-info.java file. | |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 4 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 5 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 9 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 10 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 11 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 13 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 14 |
![]() |
whitespace | WhitespaceAround | '{' is not followed by whitespace. | 14 |
![]() |
whitespace | WhitespaceAround | '}' is not preceded with whitespace. | 14 |
![]() |
misc | FinalParameters | Parameter id should be final. | 15 |
![]() |
coding | HiddenField | 'id' hides a field. | 15 |
![]() |
blocks | LeftCurly | '{' at column 26 should have line break after. | 15 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 16 |
![]() |
design | DesignForExtension | Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 17 |
![]() |
blocks | LeftCurly | '{' at column 25 should have line break after. | 17 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 18 |
![]() |
design | DesignForExtension | Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. | 19 |
![]() |
blocks | LeftCurly | '{' at column 36 should have line break after. | 19 |
![]() |
design | DesignForExtension | Method 'setDescription' is not designed for extension - needs to be abstract, final or empty. | 20 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 20 |
![]() |
misc | FinalParameters | Parameter description should be final. | 20 |
![]() |
coding | HiddenField | 'description' hides a field. | 20 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 23 |
![]() |
design | DesignForExtension | Method 'getPages' is not designed for extension - needs to be abstract, final or empty. | 24 |
![]() |
blocks | LeftCurly | '{' at column 27 should have line break after. | 24 |
![]() |
design | DesignForExtension | Method 'setPages' is not designed for extension - needs to be abstract, final or empty. | 25 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 25 |
![]() |
misc | FinalParameters | Parameter pages should be final. | 25 |
![]() |
coding | HiddenField | 'pages' hides a field. | 25 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 28 |
![]() |
design | DesignForExtension | Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. | 29 |
![]() |
blocks | LeftCurly | '{' at column 30 should have line break after. | 29 |
![]() |
design | DesignForExtension | Method 'setTitle' is not designed for extension - needs to be abstract, final or empty. | 30 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 30 |
![]() |
misc | FinalParameters | Parameter title should be final. | 30 |
![]() |
coding | HiddenField | 'title' hides a field. | 30 |
![]() |
design | DesignForExtension | Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 34 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 34 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
misc | NewlineAtEndOfFile | File does not end with a newline. | |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 9 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 10 |
![]() |
javadoc | JavadocMethod | Expected an @return tag. | 16 |
![]() |
javadoc | JavadocMethod | Expected @param tag for 'book'. | 16 |
![]() |
javadoc | JavadocMethod | Expected @throws tag for 'PersistenceException'. | 16 |
![]() |
javadoc | JavadocMethod | Expected an @return tag. | 21 |
![]() |
javadoc | JavadocMethod | Expected @param tag for 'book'. | 21 |
![]() |
javadoc | JavadocMethod | Expected @throws tag for 'PersistenceException'. | 21 |
![]() |
javadoc | JavadocMethod | Expected an @return tag. | 26 |
![]() |
javadoc | JavadocMethod | Expected @param tag for 'id'. | 26 |
![]() |
javadoc | JavadocMethod | Expected @throws tag for 'PersistenceException'. | 26 |
![]() |
javadoc | JavadocMethod | Expected @param tag for 'book'. | 31 |
![]() |
javadoc | JavadocMethod | Expected @throws tag for 'PersistenceException'. | 31 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 32 |
![]() |
javadoc | JavadocMethod | Expected an @return tag. | 37 |
![]() |
javadoc | JavadocMethod | Expected @param tag for 'start'. | 37 |
![]() |
javadoc | JavadocMethod | Expected @param tag for 'count'. | 37 |
![]() |
javadoc | JavadocMethod | Expected @throws tag for 'PersistenceException'. | 37 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 4 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 5 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 6 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 9 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 14 |
![]() |
whitespace | WhitespaceAround | '{' is not followed by whitespace. | 14 |
![]() |
whitespace | WhitespaceAround | '}' is not preceded with whitespace. | 14 |
![]() |
misc | FinalParameters | Parameter message should be final. | 15 |
![]() |
blocks | LeftCurly | '{' at column 41 should have line break after. | 15 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 16 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 17 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 22 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 23 |
![]() |
misc | FinalParameters | Parameter message should be final. | 23 |
![]() |
misc | FinalParameters | Parameter rootCause should be final. | 23 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 26 |
![]() |
misc | FinalParameters | Parameter rootCause should be final. | 26 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
imports | UnusedImports | Unused import - java.sql.Statement. | 8 |
![]() |
javadoc | JavadocType | Missing a Javadoc comment. | 15 |
![]() |
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 16 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 16 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 17 |
![]() |
design | DesignForExtension | Method 'setConnection' is not designed for extension - needs to be abstract, final or empty. | 18 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 18 |
![]() |
misc | FinalParameters | Parameter connection should be final. | 18 |
![]() |
coding | HiddenField | 'connection' hides a field. | 18 |
![]() |
design | DesignForExtension | Method 'create' is not designed for extension - needs to be abstract, final or empty. | 22 |
![]() |
misc | FinalParameters | Parameter book should be final. | 23 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 100). | 24 |
![]() |
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 24 |
![]() |
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 24 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 85). | 25 |
![]() |
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 25 |
![]() |
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 25 |
![]() |
whitespace | WhitespaceAround | '{' is not preceded with whitespace. | 25 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 27 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 89). | 34 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 35 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 41 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 43 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 86). | 44 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 47 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 107). | 48 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 48 |
![]() |
misc | FinalParameters | Parameter c should be final. | 48 |
![]() |
misc | FinalParameters | Parameter book should be final. | 48 |
![]() |
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 49 |
![]() |
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 49 |
![]() |
whitespace | OperatorWrap | '+' should be on a new line. | 50 |
![]() |
coding | MagicNumber | '3' is a magic number. | 54 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 57 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 90). | 58 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 58 |
![]() |
misc | FinalParameters | Parameter c should be final. | 58 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 85). | 59 |
![]() |
design | DesignForExtension | Method 'update' is not designed for extension - needs to be abstract, final or empty. | 63 |
![]() |
misc | FinalParameters | Parameter book should be final. | 64 |
![]() |
design | DesignForExtension | Method 'get' is not designed for extension - needs to be abstract, final or empty. | 69 |
![]() |
misc | FinalParameters | Parameter id should be final. | 70 |
![]() |
misc | FinalParameters | Parameter book should be final. | 76 |
![]() |
design | DesignForExtension | Method 'findAll' is not designed for extension - needs to be abstract, final or empty. | 81 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 85). | 82 |
![]() |
misc | FinalParameters | Parameter start should be final. | 82 |
![]() |
misc | FinalParameters | Parameter count should be final. | 82 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 9 |
![]() |
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 13 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 13 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 14 |
![]() |
design | DesignForExtension | Method 'setEntityManager' is not designed for extension - needs to be abstract, final or empty. | 15 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 15 |
![]() |
misc | FinalParameters | Parameter em should be final. | 15 |
![]() |
coding | HiddenField | 'em' hides a field. | 15 |
![]() |
design | DesignForExtension | Method 'create' is not designed for extension - needs to be abstract, final or empty. | 19 |
![]() |
misc | FinalParameters | Parameter book should be final. | 20 |
![]() |
design | DesignForExtension | Method 'update' is not designed for extension - needs to be abstract, final or empty. | 25 |
![]() |
misc | FinalParameters | Parameter book should be final. | 26 |
![]() |
design | DesignForExtension | Method 'get' is not designed for extension - needs to be abstract, final or empty. | 30 |
![]() |
misc | FinalParameters | Parameter id should be final. | 31 |
![]() |
design | DesignForExtension | Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 35 |
![]() |
misc | FinalParameters | Parameter book should be final. | 36 |
![]() |
design | DesignForExtension | Method 'findAll' is not designed for extension - needs to be abstract, final or empty. | 40 |
![]() |
misc | FinalParameters | Parameter offset should be final. | 41 |
![]() |
misc | FinalParameters | Parameter limit should be final. | 41 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocPackage | Missing package-info.java file. | |
![]() |
javadoc | JavadocType | Missing a Javadoc comment. | 11 |
![]() |
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 12 |
![]() |
javadoc | JavadocVariable | Missing a Javadoc comment. | 12 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 13 |
![]() |
design | DesignForExtension | Method 'setEntityManager' is not designed for extension - needs to be abstract, final or empty. | 14 |
![]() |
javadoc | JavadocMethod | Missing a Javadoc comment. | 14 |
![]() |
misc | FinalParameters | Parameter em should be final. | 14 |
![]() |
coding | HiddenField | 'em' hides a field. | 14 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 17 |
![]() |
design | DesignForExtension | Method 'create' is not designed for extension - needs to be abstract, final or empty. | 18 |
![]() |
misc | FinalParameters | Parameter book should be final. | 19 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 84). | 21 |
![]() |
whitespace | OperatorWrap | '+' should be on a new line. | 21 |
![]() |
coding | MagicNumber | '3' is a magic number. | 25 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 27 |
![]() |
whitespace | WhitespaceAfter | 'typecast' is not followed by whitespace. | 28 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 36 |
![]() |
regexp | RegexpSingleline | Line has trailing spaces. | 37 |
![]() |
design | DesignForExtension | Method 'update' is not designed for extension - needs to be abstract, final or empty. | 41 |
![]() |
misc | FinalParameters | Parameter book should be final. | 42 |
![]() |
design | DesignForExtension | Method 'get' is not designed for extension - needs to be abstract, final or empty. | 47 |
![]() |
misc | FinalParameters | Parameter id should be final. | 48 |
![]() |
misc | FinalParameters | Parameter book should be final. | 54 |
![]() |
design | DesignForExtension | Method 'findAll' is not designed for extension - needs to be abstract, final or empty. | 59 |
![]() |
sizes | LineLength | Line is longer than 80 characters (found 85). | 60 |
![]() |
misc | FinalParameters | Parameter start should be final. | 60 |
![]() |
misc | FinalParameters | Parameter count should be final. | 60 |