Checkstyle Results

The following document contains the results of Checkstyle 6.18 with sun_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
7 0 0 260

Files

File  I  W  E
ejava/examples/blpurchase/bl/Catalog.java 0 0 6
ejava/examples/blpurchase/bl/Purchasing.java 0 0 8
ejava/examples/blpurchase/blimpl/CatalogImpl.java 0 0 23
ejava/examples/blpurchase/blimpl/PurchasingImpl.java 0 0 40
ejava/examples/blpurchase/bo/Account.java 0 0 85
ejava/examples/blpurchase/bo/Cart.java 0 0 39
ejava/examples/blpurchase/bo/Product.java 0 0 59

Rules

Category Rule Violations Severity
coding HiddenField 20  Error
MagicNumber 2  Error
design DesignForExtension 31  Error
javadoc JavadocMethod 42  Error
JavadocPackage 3  Error
JavadocStyle 1  Error
JavadocType 2  Error
JavadocVariable 19  Error
misc FinalParameters 30  Error
NewlineAtEndOfFile 1  Error
naming ConstantName 2  Error
regexp RegexpSingleline
  • format: "\s+$"
  • maximum: "0"
  • message: "Line has trailing spaces."
  • minimum: "0"
 25  Error
sizes LineLength 10  Error
whitespace FileTabCharacter 7  Error
WhitespaceAfter 1  Error
WhitespaceAround 64  Error

Details

ejava/examples/blpurchase/bl/Catalog.java

Severity Category Rule Message Line
 Error regexp RegexpSingleline Line has trailing spaces. 8
 Error whitespace FileTabCharacter File contains tab characters (this is the first instance). 12
 Error javadoc JavadocMethod Expected @param tag for 'offset'. 18
 Error javadoc JavadocMethod Expected @param tag for 'limit'. 18
 Error javadoc JavadocMethod Expected @param tag for 'id'. 27
 Error javadoc JavadocMethod Expected @param tag for 'validEmail'. 27

ejava/examples/blpurchase/bl/Purchasing.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error whitespace FileTabCharacter File contains tab characters (this is the first instance). 9
 Error javadoc JavadocMethod Expected @param tag for 'email'. 16
 Error javadoc JavadocMethod Expected @param tag for 'firstName'. 16
 Error javadoc JavadocMethod Expected @param tag for 'lastName'. 16
 Error regexp RegexpSingleline Line has trailing spaces. 21
 Error javadoc JavadocMethod Expected @param tag for 'email'. 27
 Error javadoc JavadocMethod Expected @param tag for 'password'. 27

ejava/examples/blpurchase/blimpl/CatalogImpl.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline.
 Error javadoc JavadocType Missing a Javadoc comment. 16
 Error sizes LineLength Line is longer than 80 characters (found 88). 17
 Error whitespace FileTabCharacter File contains tab characters (this is the first instance). 17
 Error javadoc JavadocVariable Missing a Javadoc comment. 17
 Error naming ConstantName Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 17
 Error javadoc JavadocVariable Missing a Javadoc comment. 18
 Error design DesignForExtension Method 'setEntityManager' is not designed for extension - needs to be abstract, final or empty. 20
 Error javadoc JavadocMethod Missing a Javadoc comment. 20
 Error misc FinalParameters Parameter entityManager should be final. 20
 Error design DesignForExtension Method 'getProducts' is not designed for extension - needs to be abstract, final or empty. 24
 Error misc FinalParameters Parameter offset should be final. 25
 Error misc FinalParameters Parameter limit should be final. 25
 Error sizes LineLength Line is longer than 80 characters (found 107). 26
 Error design DesignForExtension Method 'addToCart' is not designed for extension - needs to be abstract, final or empty. 36
 Error misc FinalParameters Parameter id should be final. 37
 Error misc FinalParameters Parameter email should be final. 37
 Error whitespace WhitespaceAround '-' is not preceded with whitespace. 43
 Error whitespace WhitespaceAround '-' is not followed by whitespace. 43
 Error whitespace WhitespaceAround '-' is not preceded with whitespace. 47
 Error whitespace WhitespaceAround '-' is not followed by whitespace. 47
 Error sizes LineLength Line is longer than 80 characters (found 83). 52
 Error regexp RegexpSingleline Line has trailing spaces. 63

ejava/examples/blpurchase/blimpl/PurchasingImpl.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error sizes LineLength Line is longer than 80 characters (found 91). 20
 Error whitespace FileTabCharacter File contains tab characters (this is the first instance). 20
 Error javadoc JavadocVariable Missing a Javadoc comment. 20
 Error naming ConstantName Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 20
 Error javadoc JavadocVariable Missing a Javadoc comment. 21
 Error javadoc JavadocVariable Missing a Javadoc comment. 22
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 22
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 22
 Error regexp RegexpSingleline Line has trailing spaces. 23
 Error design DesignForExtension Method 'setEntityManager' is not designed for extension - needs to be abstract, final or empty. 24
 Error javadoc JavadocMethod Missing a Javadoc comment. 24
 Error misc FinalParameters Parameter em should be final. 24
 Error coding HiddenField 'em' hides a field. 24
 Error design DesignForExtension Method 'createAccount' is not designed for extension - needs to be abstract, final or empty. 28
 Error sizes LineLength Line is longer than 80 characters (found 87). 29
 Error misc FinalParameters Parameter email should be final. 29
 Error misc FinalParameters Parameter firstName should be final. 29
 Error misc FinalParameters Parameter lastName should be final. 29
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 30
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 30
 Error whitespace WhitespaceAround '==' is not preceded with whitespace. 35
 Error whitespace WhitespaceAround '==' is not followed by whitespace. 35
 Error sizes LineLength Line is longer than 80 characters (found 82). 36
 Error sizes LineLength Line is longer than 80 characters (found 85). 43
 Error design DesignForExtension Method 'checkout' is not designed for extension - needs to be abstract, final or empty. 46
 Error misc FinalParameters Parameter email should be final. 47
 Error misc FinalParameters Parameter password should be final. 47
 Error regexp RegexpSingleline Line has trailing spaces. 53
 Error regexp RegexpSingleline Line has trailing spaces. 59
 Error sizes LineLength Line is longer than 80 characters (found 101). 65
 Error regexp RegexpSingleline Line has trailing spaces. 68
 Error javadoc JavadocMethod Missing a Javadoc comment. 72
 Error coding MagicNumber '8' is a magic number. 73
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 74
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 74
 Error whitespace WhitespaceAround '<' is not preceded with whitespace. 74
 Error whitespace WhitespaceAround '<' is not followed by whitespace. 74
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 75
 Error coding MagicNumber '25' is a magic number. 75

ejava/examples/blpurchase/bo/Account.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocStyle First sentence should end with a period. 11
 Error regexp RegexpSingleline Line has trailing spaces. 12
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 15
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 15
 Error regexp RegexpSingleline Line has trailing spaces. 17
 Error whitespace FileTabCharacter File contains tab characters (this is the first instance). 17
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 17
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 17
 Error sizes LineLength Line is longer than 80 characters (found 81). 18
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 18
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 18
 Error sizes LineLength Line is longer than 80 characters (found 89). 21
 Error javadoc JavadocVariable Missing a Javadoc comment. 21
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 21
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 21
 Error regexp RegexpSingleline Line has trailing spaces. 22
 Error javadoc JavadocVariable Missing a Javadoc comment. 23
 Error regexp RegexpSingleline Line has trailing spaces. 25
 Error javadoc JavadocVariable Missing a Javadoc comment. 26
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 26
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 26
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 26
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 26
 Error regexp RegexpSingleline Line has trailing spaces. 28
 Error javadoc JavadocVariable Missing a Javadoc comment. 29
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 29
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 29
 Error regexp RegexpSingleline Line has trailing spaces. 31
 Error javadoc JavadocVariable Missing a Javadoc comment. 32
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 32
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 32
 Error regexp RegexpSingleline Line has trailing spaces. 34
 Error javadoc JavadocVariable Missing a Javadoc comment. 35
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 35
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 35
 Error javadoc JavadocMethod Missing a Javadoc comment. 38
 Error whitespace WhitespaceAround '{' is not preceded with whitespace. 38
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 38
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 38
 Error javadoc JavadocMethod Missing a Javadoc comment. 39
 Error misc FinalParameters Parameter email should be final. 39
 Error coding HiddenField 'email' hides a field. 39
 Error misc FinalParameters Parameter firstName should be final. 39
 Error coding HiddenField 'firstName' hides a field. 39
 Error misc FinalParameters Parameter lastName should be final. 39
 Error coding HiddenField 'lastName' hides a field. 39
 Error regexp RegexpSingleline Line has trailing spaces. 44
 Error design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 45
 Error javadoc JavadocMethod Missing a Javadoc comment. 45
 Error design DesignForExtension Method 'setId' is not designed for extension - needs to be abstract, final or empty. 48
 Error javadoc JavadocMethod Missing a Javadoc comment. 48
 Error misc FinalParameters Parameter id should be final. 48
 Error coding HiddenField 'id' hides a field. 48
 Error regexp RegexpSingleline Line has trailing spaces. 51
 Error design DesignForExtension Method 'getEmail' is not designed for extension - needs to be abstract, final or empty. 52
 Error javadoc JavadocMethod Missing a Javadoc comment. 52
 Error design DesignForExtension Method 'setEmail' is not designed for extension - needs to be abstract, final or empty. 55
 Error javadoc JavadocMethod Missing a Javadoc comment. 55
 Error misc FinalParameters Parameter email should be final. 55
 Error coding HiddenField 'email' hides a field. 55
 Error regexp RegexpSingleline Line has trailing spaces. 58
 Error design DesignForExtension Method 'getPassword' is not designed for extension - needs to be abstract, final or empty. 59
 Error javadoc JavadocMethod Missing a Javadoc comment. 59
 Error design DesignForExtension Method 'setPassword' is not designed for extension - needs to be abstract, final or empty. 62
 Error javadoc JavadocMethod Missing a Javadoc comment. 62
 Error misc FinalParameters Parameter password should be final. 62
 Error coding HiddenField 'password' hides a field. 62
 Error regexp RegexpSingleline Line has trailing spaces. 65
 Error design DesignForExtension Method 'getFirstName' is not designed for extension - needs to be abstract, final or empty. 66
 Error javadoc JavadocMethod Missing a Javadoc comment. 66
 Error design DesignForExtension Method 'setFirstName' is not designed for extension - needs to be abstract, final or empty. 69
 Error javadoc JavadocMethod Missing a Javadoc comment. 69
 Error misc FinalParameters Parameter firstName should be final. 69
 Error coding HiddenField 'firstName' hides a field. 69
 Error regexp RegexpSingleline Line has trailing spaces. 72
 Error design DesignForExtension Method 'getLastName' is not designed for extension - needs to be abstract, final or empty. 73
 Error javadoc JavadocMethod Missing a Javadoc comment. 73
 Error design DesignForExtension Method 'setLastName' is not designed for extension - needs to be abstract, final or empty. 76
 Error javadoc JavadocMethod Missing a Javadoc comment. 76
 Error misc FinalParameters Parameter lastName should be final. 76
 Error coding HiddenField 'lastName' hides a field. 76
 Error design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 80
 Error regexp RegexpSingleline Line has trailing spaces. 89
 Error regexp RegexpSingleline Line has trailing spaces. 90

ejava/examples/blpurchase/bo/Cart.java

Severity Category Rule Message Line
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 17
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 17
 Error whitespace FileTabCharacter File contains tab characters (this is the first instance). 19
 Error javadoc JavadocVariable Missing a Javadoc comment. 19
 Error regexp RegexpSingleline Line has trailing spaces. 21
 Error javadoc JavadocVariable Missing a Javadoc comment. 22
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 23
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 23
 Error regexp RegexpSingleline Line has trailing spaces. 25
 Error javadoc JavadocVariable Missing a Javadoc comment. 26
 Error javadoc JavadocMethod Missing a Javadoc comment. 29
 Error whitespace WhitespaceAround '{' is not preceded with whitespace. 29
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 29
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 29
 Error javadoc JavadocMethod Missing a Javadoc comment. 30
 Error misc FinalParameters Parameter account should be final. 30
 Error coding HiddenField 'account' hides a field. 30
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 31
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 31
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 32
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 32
 Error design DesignForExtension Method 'getEmail' is not designed for extension - needs to be abstract, final or empty. 35
 Error javadoc JavadocMethod Missing a Javadoc comment. 35
 Error design DesignForExtension Method 'setEmail' is not designed for extension - needs to be abstract, final or empty. 38
 Error javadoc JavadocMethod Missing a Javadoc comment. 38
 Error misc FinalParameters Parameter email should be final. 38
 Error coding HiddenField 'email' hides a field. 38
 Error design DesignForExtension Method 'getAccount' is not designed for extension - needs to be abstract, final or empty. 42
 Error javadoc JavadocMethod Missing a Javadoc comment. 42
 Error design DesignForExtension Method 'setAccount' is not designed for extension - needs to be abstract, final or empty. 46
 Error javadoc JavadocMethod Missing a Javadoc comment. 46
 Error misc FinalParameters Parameter account should be final. 46
 Error coding HiddenField 'account' hides a field. 46
 Error design DesignForExtension Method 'getProducts' is not designed for extension - needs to be abstract, final or empty. 50
 Error javadoc JavadocMethod Missing a Javadoc comment. 50
 Error design DesignForExtension Method 'setProducts' is not designed for extension - needs to be abstract, final or empty. 54
 Error javadoc JavadocMethod Missing a Javadoc comment. 54
 Error misc FinalParameters Parameter products should be final. 54
 Error coding HiddenField 'products' hides a field. 54

ejava/examples/blpurchase/bo/Product.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 10
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 11
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 11
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 12
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 12
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 12
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 12
 Error regexp RegexpSingleline Line has trailing spaces. 14
 Error javadoc JavadocVariable Missing a Javadoc comment. 14
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 14
 Error whitespace FileTabCharacter File contains tab characters (this is the first instance). 15
 Error javadoc JavadocVariable Missing a Javadoc comment. 15
 Error regexp RegexpSingleline Line has trailing spaces. 16
 Error javadoc JavadocVariable Missing a Javadoc comment. 17
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 17
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 17
 Error javadoc JavadocVariable Missing a Javadoc comment. 19
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 19
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 19
 Error javadoc JavadocVariable Missing a Javadoc comment. 21
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 21
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 21
 Error javadoc JavadocMethod Missing a Javadoc comment. 24
 Error whitespace WhitespaceAround '{' is not preceded with whitespace. 24
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 24
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 24
 Error javadoc JavadocMethod Missing a Javadoc comment. 25
 Error misc FinalParameters Parameter name should be final. 25
 Error coding HiddenField 'name' hides a field. 25
 Error misc FinalParameters Parameter price should be final. 25
 Error coding HiddenField 'price' hides a field. 25
 Error misc FinalParameters Parameter count should be final. 25
 Error coding HiddenField 'count' hides a field. 25
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 28
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 28
 Error design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 30
 Error javadoc JavadocMethod Missing a Javadoc comment. 30
 Error design DesignForExtension Method 'setId' is not designed for extension - needs to be abstract, final or empty. 33
 Error javadoc JavadocMethod Missing a Javadoc comment. 33
 Error misc FinalParameters Parameter id should be final. 33
 Error coding HiddenField 'id' hides a field. 33
 Error design DesignForExtension Method 'getName' is not designed for extension - needs to be abstract, final or empty. 36
 Error javadoc JavadocMethod Missing a Javadoc comment. 36
 Error design DesignForExtension Method 'setName' is not designed for extension - needs to be abstract, final or empty. 39
 Error javadoc JavadocMethod Missing a Javadoc comment. 39
 Error misc FinalParameters Parameter name should be final. 39
 Error coding HiddenField 'name' hides a field. 39
 Error design DesignForExtension Method 'getPrice' is not designed for extension - needs to be abstract, final or empty. 42
 Error javadoc JavadocMethod Missing a Javadoc comment. 42
 Error design DesignForExtension Method 'setPrice' is not designed for extension - needs to be abstract, final or empty. 45
 Error javadoc JavadocMethod Missing a Javadoc comment. 45
 Error misc FinalParameters Parameter price should be final. 45
 Error coding HiddenField 'price' hides a field. 45
 Error design DesignForExtension Method 'getCount' is not designed for extension - needs to be abstract, final or empty. 48
 Error javadoc JavadocMethod Missing a Javadoc comment. 48
 Error design DesignForExtension Method 'setCount' is not designed for extension - needs to be abstract, final or empty. 51
 Error javadoc JavadocMethod Missing a Javadoc comment. 51
 Error misc FinalParameters Parameter count should be final. 51
 Error coding HiddenField 'count' hides a field. 51