The following document contains the results of Checkstyle 6.18 with sun_checks.xml ruleset.
Category | Rule | Violations | Severity |
---|---|---|---|
blocks | RightCurly | 2 | Error |
coding | MagicNumber | 1 | Error |
design | DesignForExtension | 19 | Error |
javadoc | JavadocMethod | 20 | Error |
JavadocPackage | 1 | Error | |
JavadocType | 4 | Error | |
JavadocVariable | 10 | Error | |
misc | FinalParameters | 16 | Error |
naming | ConstantName | 3 | Error |
regexp | RegexpSingleline
|
38 | Error |
sizes | LineLength | 3 | Error |
whitespace | FileTabCharacter | 2 | Error |
OperatorWrap | 1 | Error | |
WhitespaceAfter | 3 | Error | |
WhitespaceAround | 10 | Error |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | regexp | RegexpSingleline | Line has trailing spaces. | 26 |
Error | sizes | LineLength | Line is longer than 80 characters (found 90). | 33 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
Error | naming | ConstantName | Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 33 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 34 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
Error | whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 35 |
Error | whitespace | WhitespaceAround | '=' is not followed by whitespace. | 35 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 37 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 43 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 45 |
Error | design | DesignForExtension | Method 'init' is not designed for extension - needs to be abstract, final or empty. | 50 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 55 |
Error | whitespace | WhitespaceAfter | 'typecast' is not followed by whitespace. | 57 |
Error | whitespace | WhitespaceAfter | 'typecast' is not followed by whitespace. | 59 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 61 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 64 |
Error | design | DesignForExtension | Method 'close' is not designed for extension - needs to be abstract, final or empty. | 67 |
Error | whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 69 |
Error | whitespace | WhitespaceAround | '=' is not followed by whitespace. | 69 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 70 |
Error | design | DesignForExtension | Method 'cancelReservation' is not designed for extension - needs to be abstract, final or empty. | 76 |
Error | misc | FinalParameters | Parameter reservation should be final. | 76 |
Error | javadoc | JavadocMethod | Expected @param tag for 'reservation'. | 76 |
Error | javadoc | JavadocMethod | Expected @throws tag for 'HotelReservationException'. | 77 |
Error | blocks | RightCurly | '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). | 80 |
Error | javadoc | JavadocMethod | Expected an @return tag. | 92 |
Error | design | DesignForExtension | Method 'commitReservation' is not designed for extension - needs to be abstract, final or empty. | 92 |
Error | misc | FinalParameters | Parameter reservation should be final. | 92 |
Error | javadoc | JavadocMethod | Expected @param tag for 'reservation'. | 92 |
Error | javadoc | JavadocMethod | Expected @throws tag for 'HotelReservationException'. | 93 |
Error | javadoc | JavadocMethod | Expected an @return tag. | 101 |
Error | design | DesignForExtension | Method 'createReservation' is not designed for extension - needs to be abstract, final or empty. | 101 |
Error | misc | FinalParameters | Parameter person should be final. | 101 |
Error | javadoc | JavadocMethod | Expected @param tag for 'person'. | 101 |
Error | misc | FinalParameters | Parameter startDate should be final. | 101 |
Error | javadoc | JavadocMethod | Expected @param tag for 'startDate'. | 101 |
Error | misc | FinalParameters | Parameter endDate should be final. | 102 |
Error | javadoc | JavadocMethod | Expected @param tag for 'endDate'. | 102 |
Error | javadoc | JavadocMethod | Expected @throws tag for 'HotelReservationException'. | 102 |
Error | blocks | RightCurly | '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). | 105 |
Error | design | DesignForExtension | Method 'getReservations' is not designed for extension - needs to be abstract, final or empty. | 114 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 114 |
Error | misc | FinalParameters | Parameter index should be final. | 114 |
Error | misc | FinalParameters | Parameter count should be final. | 114 |
Error | design | DesignForExtension | Method 'getReservationsForPerson' is not designed for extension - needs to be abstract, final or empty. | 119 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 119 |
Error | misc | FinalParameters | Parameter person should be final. | 119 |
Error | misc | FinalParameters | Parameter index should be final. | 119 |
Error | misc | FinalParameters | Parameter count should be final. | 120 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 124 |
Error | design | DesignForExtension | Method 'getReservationByConfirmation' is not designed for extension - needs to be abstract, final or empty. | 124 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 124 |
Error | misc | FinalParameters | Parameter confirmation should be final. | 124 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 129 |
Error | design | DesignForExtension | Method 'cleanupReservation' is not designed for extension - needs to be abstract, final or empty. | 129 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 129 |
Error | misc | FinalParameters | Parameter confirmation should be final. | 129 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | javadoc | JavadocType | Missing a Javadoc comment. | 7 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | javadoc | JavadocType | Missing a Javadoc comment. | 7 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | regexp | RegexpSingleline | Line has trailing spaces. | 29 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 32 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 34 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 35 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 42 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 43 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 44 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 50 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 51 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 53 |
Error | whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 59 |
Error | coding | MagicNumber | '3' is a magic number. | 59 |
Error | whitespace | WhitespaceAround | '=' is not followed by whitespace. | 59 |
Error | whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 59 |
Error | whitespace | WhitespaceAround | '=' is not followed by whitespace. | 59 |
Error | sizes | LineLength | Line is longer than 80 characters (found 96). | 63 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 63 |
Error | naming | ConstantName | Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 63 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 64 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 65 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 66 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 68 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 70 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 71 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 75 |
Error | design | DesignForExtension | Method 'init' is not designed for extension - needs to be abstract, final or empty. | 79 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 82 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 86 |
Error | whitespace | WhitespaceAfter | 'typecast' is not followed by whitespace. | 89 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 91 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 94 |
Error | design | DesignForExtension | Method 'closing' is not designed for extension - needs to be abstract, final or empty. | 96 |
Error | design | DesignForExtension | Method 'close' is not designed for extension - needs to be abstract, final or empty. | 104 |
Error | design | DesignForExtension | Method 'createReservation' is not designed for extension - needs to be abstract, final or empty. | 110 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 110 |
Error | misc | FinalParameters | Parameter person should be final. | 110 |
Error | misc | FinalParameters | Parameter startDate should be final. | 110 |
Error | misc | FinalParameters | Parameter endDate should be final. | 110 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 114 |
Error | design | DesignForExtension | Method 'cancelReservations' is not designed for extension - needs to be abstract, final or empty. | 115 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 115 |
Error | design | DesignForExtension | Method 'commit' is not designed for extension - needs to be abstract, final or empty. | 119 |
Error | javadoc | JavadocMethod | Missing a Javadoc comment. | 119 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 124 |
Error | design | DesignForExtension | Method 'afterBegin' is not designed for extension - needs to be abstract, final or empty. | 127 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 128 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 131 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 132 |
Error | design | DesignForExtension | Method 'beforeCompletion' is not designed for extension - needs to be abstract, final or empty. | 134 |
Error | javadoc | JavadocMethod | Expected @throws tag for 'EJBException'. | 134 |
Error | javadoc | JavadocMethod | Expected @throws tag for 'RemoteException'. | 134 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 135 |
Error | whitespace | OperatorWrap | '+' should be on a new line. | 135 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 137 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 139 |
Error | design | DesignForExtension | Method 'afterCompletion' is not designed for extension - needs to be abstract, final or empty. | 141 |
Error | misc | FinalParameters | Parameter status should be final. | 141 |
Error | javadoc | JavadocMethod | Expected @param tag for 'status'. | 141 |
Error | regexp | RegexpSingleline | Line has trailing spaces. | 142 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | javadoc | JavadocType | Missing a Javadoc comment. | 7 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | javadoc | JavadocPackage | Missing package-info.java file. | |
Error | javadoc | JavadocType | Missing a Javadoc comment. | 7 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | sizes | LineLength | Line is longer than 80 characters (found 81). | 15 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 15 |
Error | naming | ConstantName | Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 15 |
Error | javadoc | JavadocVariable | Missing a Javadoc comment. | 17 |
Error | whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 17 |
Error | whitespace | WhitespaceAround | '=' is not followed by whitespace. | 17 |
Error | design | DesignForExtension | Method 'reset' is not designed for extension - needs to be abstract, final or empty. | 20 |
Error | whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 21 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
Error | whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 10 |