The following document contains the results of Checkstyle 6.18 with sun_checks.xml ruleset. 
| Category | Rule | Violations | Severity |
|---|---|---|---|
| blocks | RightCurly | 2 | |
| coding | MagicNumber | 1 | |
| design | DesignForExtension | 19 | |
| javadoc | JavadocMethod | 20 | |
| JavadocPackage | 1 | ||
| JavadocType | 4 | ||
| JavadocVariable | 10 | ||
| misc | FinalParameters | 16 | |
| naming | ConstantName | 3 | |
| regexp | RegexpSingleline
|
38 | |
| sizes | LineLength | 3 | |
| whitespace | FileTabCharacter | 2 | |
| OperatorWrap | 1 | ||
| WhitespaceAfter | 3 | ||
| WhitespaceAround | 10 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| regexp | RegexpSingleline | Line has trailing spaces. | 26 | |
| sizes | LineLength | Line is longer than 80 characters (found 90). | 33 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 33 | |
| naming | ConstantName | Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 33 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 34 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 35 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 35 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 35 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 37 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 38 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 42 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 43 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 45 | |
| design | DesignForExtension | Method 'init' is not designed for extension - needs to be abstract, final or empty. | 50 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 55 | |
| whitespace | WhitespaceAfter | 'typecast' is not followed by whitespace. | 57 | |
| whitespace | WhitespaceAfter | 'typecast' is not followed by whitespace. | 59 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 61 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 64 | |
| design | DesignForExtension | Method 'close' is not designed for extension - needs to be abstract, final or empty. | 67 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 69 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 69 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 70 | |
| design | DesignForExtension | Method 'cancelReservation' is not designed for extension - needs to be abstract, final or empty. | 76 | |
| misc | FinalParameters | Parameter reservation should be final. | 76 | |
| javadoc | JavadocMethod | Expected @param tag for 'reservation'. | 76 | |
| javadoc | JavadocMethod | Expected @throws tag for 'HotelReservationException'. | 77 | |
| blocks | RightCurly | '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). | 80 | |
| javadoc | JavadocMethod | Expected an @return tag. | 92 | |
| design | DesignForExtension | Method 'commitReservation' is not designed for extension - needs to be abstract, final or empty. | 92 | |
| misc | FinalParameters | Parameter reservation should be final. | 92 | |
| javadoc | JavadocMethod | Expected @param tag for 'reservation'. | 92 | |
| javadoc | JavadocMethod | Expected @throws tag for 'HotelReservationException'. | 93 | |
| javadoc | JavadocMethod | Expected an @return tag. | 101 | |
| design | DesignForExtension | Method 'createReservation' is not designed for extension - needs to be abstract, final or empty. | 101 | |
| misc | FinalParameters | Parameter person should be final. | 101 | |
| javadoc | JavadocMethod | Expected @param tag for 'person'. | 101 | |
| misc | FinalParameters | Parameter startDate should be final. | 101 | |
| javadoc | JavadocMethod | Expected @param tag for 'startDate'. | 101 | |
| misc | FinalParameters | Parameter endDate should be final. | 102 | |
| javadoc | JavadocMethod | Expected @param tag for 'endDate'. | 102 | |
| javadoc | JavadocMethod | Expected @throws tag for 'HotelReservationException'. | 102 | |
| blocks | RightCurly | '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). | 105 | |
| design | DesignForExtension | Method 'getReservations' is not designed for extension - needs to be abstract, final or empty. | 114 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 114 | |
| misc | FinalParameters | Parameter index should be final. | 114 | |
| misc | FinalParameters | Parameter count should be final. | 114 | |
| design | DesignForExtension | Method 'getReservationsForPerson' is not designed for extension - needs to be abstract, final or empty. | 119 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 119 | |
| misc | FinalParameters | Parameter person should be final. | 119 | |
| misc | FinalParameters | Parameter index should be final. | 119 | |
| misc | FinalParameters | Parameter count should be final. | 120 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 124 | |
| design | DesignForExtension | Method 'getReservationByConfirmation' is not designed for extension - needs to be abstract, final or empty. | 124 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 124 | |
| misc | FinalParameters | Parameter confirmation should be final. | 124 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 129 | |
| design | DesignForExtension | Method 'cleanupReservation' is not designed for extension - needs to be abstract, final or empty. | 129 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 129 | |
| misc | FinalParameters | Parameter confirmation should be final. | 129 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocType | Missing a Javadoc comment. | 7 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocType | Missing a Javadoc comment. | 7 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| regexp | RegexpSingleline | Line has trailing spaces. | 29 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 32 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 34 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 35 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 42 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 43 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 44 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 50 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 51 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 53 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 59 | |
| coding | MagicNumber | '3' is a magic number. | 59 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 59 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 59 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 59 | |
| sizes | LineLength | Line is longer than 80 characters (found 96). | 63 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 63 | |
| naming | ConstantName | Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 63 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 64 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 65 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 66 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 68 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 70 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 71 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 75 | |
| design | DesignForExtension | Method 'init' is not designed for extension - needs to be abstract, final or empty. | 79 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 82 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 86 | |
| whitespace | WhitespaceAfter | 'typecast' is not followed by whitespace. | 89 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 91 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 94 | |
| design | DesignForExtension | Method 'closing' is not designed for extension - needs to be abstract, final or empty. | 96 | |
| design | DesignForExtension | Method 'close' is not designed for extension - needs to be abstract, final or empty. | 104 | |
| design | DesignForExtension | Method 'createReservation' is not designed for extension - needs to be abstract, final or empty. | 110 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 110 | |
| misc | FinalParameters | Parameter person should be final. | 110 | |
| misc | FinalParameters | Parameter startDate should be final. | 110 | |
| misc | FinalParameters | Parameter endDate should be final. | 110 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 114 | |
| design | DesignForExtension | Method 'cancelReservations' is not designed for extension - needs to be abstract, final or empty. | 115 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 115 | |
| design | DesignForExtension | Method 'commit' is not designed for extension - needs to be abstract, final or empty. | 119 | |
| javadoc | JavadocMethod | Missing a Javadoc comment. | 119 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 124 | |
| design | DesignForExtension | Method 'afterBegin' is not designed for extension - needs to be abstract, final or empty. | 127 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 128 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 131 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 132 | |
| design | DesignForExtension | Method 'beforeCompletion' is not designed for extension - needs to be abstract, final or empty. | 134 | |
| javadoc | JavadocMethod | Expected @throws tag for 'EJBException'. | 134 | |
| javadoc | JavadocMethod | Expected @throws tag for 'RemoteException'. | 134 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 135 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 135 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 137 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 139 | |
| design | DesignForExtension | Method 'afterCompletion' is not designed for extension - needs to be abstract, final or empty. | 141 | |
| misc | FinalParameters | Parameter status should be final. | 141 | |
| javadoc | JavadocMethod | Expected @param tag for 'status'. | 141 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 142 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocType | Missing a Javadoc comment. | 7 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | JavadocPackage | Missing package-info.java file. | ||
| javadoc | JavadocType | Missing a Javadoc comment. | 7 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| sizes | LineLength | Line is longer than 80 characters (found 81). | 15 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 15 | |
| naming | ConstantName | Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 15 | |
| javadoc | JavadocVariable | Missing a Javadoc comment. | 17 | |
| whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 17 | |
| whitespace | WhitespaceAround | '=' is not followed by whitespace. | 17 | |
| design | DesignForExtension | Method 'reset' is not designed for extension - needs to be abstract, final or empty. | 20 | |
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 21 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 10 |