Checkstyle Results

The following document contains the results of Checkstyle 6.18 with sun_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
3 0 0 92

Files

File  I  W  E
ejava/examples/txhotel/dao/DAOException.java 0 0 9
ejava/examples/txhotel/dao/ReservationDAO.java 0 0 11
ejava/examples/txhotel/jpa/JPAReservationDAO.java 0 0 72

Rules

Category Rule Violations Severity
blocks LeftCurly 3  Error
RightCurly 5  Error
coding HiddenField 1  Error
design DesignForExtension 8  Error
javadoc JavadocMethod 15  Error
JavadocPackage 2  Error
JavadocType 3  Error
JavadocVariable 2  Error
misc FinalParameters 16  Error
naming ConstantName 1  Error
regexp RegexpSingleline
  • format: "\s+$"
  • maximum: "0"
  • message: "Line has trailing spaces."
  • minimum: "0"
 27  Error
sizes LineLength 3  Error
whitespace OperatorWrap 5  Error
WhitespaceAround 1  Error

Details

ejava/examples/txhotel/dao/DAOException.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocType Missing a Javadoc comment. 3
 Error misc FinalParameters Parameter msg should be final. 5
 Error blocks LeftCurly '{' at column 37 should have line break after. 5
 Error misc FinalParameters Parameter ex should be final. 6
 Error blocks LeftCurly '{' at column 39 should have line break after. 6
 Error misc FinalParameters Parameter msg should be final. 7
 Error misc FinalParameters Parameter ex should be final. 7
 Error blocks LeftCurly '{' at column 51 should have line break after. 7

ejava/examples/txhotel/dao/ReservationDAO.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 8
 Error javadoc JavadocMethod Missing a Javadoc comment. 9
 Error javadoc JavadocMethod Missing a Javadoc comment. 11
 Error regexp RegexpSingleline Line has trailing spaces. 12
 Error javadoc JavadocMethod Missing a Javadoc comment. 13
 Error regexp RegexpSingleline Line has trailing spaces. 14
 Error javadoc JavadocMethod Missing a Javadoc comment. 15
 Error javadoc JavadocMethod Missing a Javadoc comment. 17
 Error javadoc JavadocMethod Missing a Javadoc comment. 19
 Error regexp RegexpSingleline Line has trailing spaces. 21
 Error javadoc JavadocMethod Missing a Javadoc comment. 21

ejava/examples/txhotel/jpa/JPAReservationDAO.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocType Missing a Javadoc comment. 18
 Error sizes LineLength Line is longer than 80 characters (found 87). 19
 Error javadoc JavadocVariable Missing a Javadoc comment. 19
 Error naming ConstantName Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 19
 Error regexp RegexpSingleline Line has trailing spaces. 20
 Error javadoc JavadocVariable Missing a Javadoc comment. 21
 Error regexp RegexpSingleline Line has trailing spaces. 22
 Error design DesignForExtension Method 'setEntityManager' is not designed for extension - needs to be abstract, final or empty. 23
 Error javadoc JavadocMethod Missing a Javadoc comment. 23
 Error misc FinalParameters Parameter em should be final. 23
 Error coding HiddenField 'em' hides a field. 23
 Error design DesignForExtension Method 'createReservation' is not designed for extension - needs to be abstract, final or empty. 27
 Error javadoc JavadocMethod Missing a Javadoc comment. 27
 Error misc FinalParameters Parameter reservation should be final. 27
 Error regexp RegexpSingleline Line has trailing spaces. 28
 Error regexp RegexpSingleline Line has trailing spaces. 31
 Error regexp RegexpSingleline Line has trailing spaces. 39
 Error regexp RegexpSingleline Line has trailing spaces. 40
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 43
 Error regexp RegexpSingleline Line has trailing spaces. 46
 Error whitespace OperatorWrap '+' should be on a new line. 46
 Error design DesignForExtension Method 'getReservation' is not designed for extension - needs to be abstract, final or empty. 51
 Error javadoc JavadocMethod Missing a Javadoc comment. 51
 Error misc FinalParameters Parameter id should be final. 51
 Error regexp RegexpSingleline Line has trailing spaces. 54
 Error sizes LineLength Line is longer than 80 characters (found 81). 54
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 57
 Error regexp RegexpSingleline Line has trailing spaces. 64
 Error design DesignForExtension Method 'getReservations' is not designed for extension - needs to be abstract, final or empty. 64
 Error javadoc JavadocMethod Missing a Javadoc comment. 64
 Error misc FinalParameters Parameter index should be final. 64
 Error misc FinalParameters Parameter count should be final. 64
 Error regexp RegexpSingleline Line has trailing spaces. 66
 Error design DesignForExtension Method 'getReservations' is not designed for extension - needs to be abstract, final or empty. 69
 Error javadoc JavadocMethod Missing a Javadoc comment. 69
 Error regexp RegexpSingleline Line has trailing spaces. 71
 Error misc FinalParameters Parameter queryName should be final. 71
 Error misc FinalParameters Parameter params should be final. 71
 Error regexp RegexpSingleline Line has trailing spaces. 72
 Error misc FinalParameters Parameter index should be final. 72
 Error misc FinalParameters Parameter count should be final. 72
 Error whitespace WhitespaceAround 'for' is not followed by whitespace. 79
 Error regexp RegexpSingleline Line has trailing spaces. 81
 Error regexp RegexpSingleline Line has trailing spaces. 85
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 86
 Error regexp RegexpSingleline Line has trailing spaces. 88
 Error whitespace OperatorWrap '+' should be on a new line. 88
 Error regexp RegexpSingleline Line has trailing spaces. 90
 Error whitespace OperatorWrap '+' should be on a new line. 90
 Error regexp RegexpSingleline Line has trailing spaces. 95
 Error design DesignForExtension Method 'removeReservation' is not designed for extension - needs to be abstract, final or empty. 95
 Error javadoc JavadocMethod Missing a Javadoc comment. 95
 Error misc FinalParameters Parameter reservation should be final. 95
 Error regexp RegexpSingleline Line has trailing spaces. 99
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 104
 Error regexp RegexpSingleline Line has trailing spaces. 107
 Error whitespace OperatorWrap '+' should be on a new line. 107
 Error sizes LineLength Line is longer than 80 characters (found 87). 112
 Error design DesignForExtension Method 'updateReservation' is not designed for extension - needs to be abstract, final or empty. 112
 Error javadoc JavadocMethod Missing a Javadoc comment. 112
 Error misc FinalParameters Parameter reservation should be final. 112
 Error regexp RegexpSingleline Line has trailing spaces. 115
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 118
 Error regexp RegexpSingleline Line has trailing spaces. 121
 Error whitespace OperatorWrap '+' should be on a new line. 121
 Error regexp RegexpSingleline Line has trailing spaces. 126
 Error design DesignForExtension Method 'getReservationByConfirmation' is not designed for extension - needs to be abstract, final or empty. 126
 Error javadoc JavadocMethod Missing a Javadoc comment. 126
 Error misc FinalParameters Parameter confirmation should be final. 126
 Error regexp RegexpSingleline Line has trailing spaces. 128
 Error regexp RegexpSingleline Line has trailing spaces. 132