Checkstyle Results

The following document contains the results of Checkstyle 6.18 with sun_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
8 0 0 244

Files

File  I  W  E
ejava/examples/txhotel/bl/HotelReservationException.java 0 0 14
ejava/examples/txhotel/bl/HotelReservationSession.java 0 0 5
ejava/examples/txhotel/bl/HotelReservationist.java 0 0 11
ejava/examples/txhotel/bl/InvalidParameterException.java 0 0 14
ejava/examples/txhotel/bl/InvalidReservationChangeException.java 0 0 16
ejava/examples/txhotel/bl/ReservationNotFoundException.java 0 0 15
ejava/examples/txhotel/bo/Person.java 0 0 65
ejava/examples/txhotel/bo/Reservation.java 0 0 104

Rules

Category Rule Violations Severity
blocks LeftCurly 12  Error
NeedBraces 2  Error
RightCurly 1  Error
coding HiddenField 20  Error
design DesignForExtension 24  Error
javadoc JavadocMethod 42  Error
JavadocPackage 2  Error
JavadocType 8  Error
JavadocVariable 11  Error
misc FinalParameters 40  Error
NewlineAtEndOfFile 1  Error
regexp RegexpSingleline
  • format: "\s+$"
  • maximum: "0"
  • message: "Line has trailing spaces."
  • minimum: "0"
 16  Error
sizes LineLength 5  Error
whitespace FileTabCharacter 2  Error
OperatorWrap 6  Error
WhitespaceAfter 6  Error
WhitespaceAround 46  Error

Details

ejava/examples/txhotel/bl/HotelReservationException.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 3
 Error javadoc JavadocMethod Missing a Javadoc comment. 5
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 5
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 5
 Error misc FinalParameters Parameter msg should be final. 6
 Error blocks LeftCurly '{' at column 50 should have line break after. 6
 Error misc FinalParameters Parameter msg should be final. 7
 Error misc FinalParameters Parameter ex should be final. 7
 Error blocks LeftCurly '{' at column 64 should have line break after. 7
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 7
 Error whitespace WhitespaceAfter ';' is not followed by whitespace. 7
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 7
 Error misc FinalParameters Parameter ex should be final. 8
 Error blocks LeftCurly '{' at column 52 should have line break after. 8

ejava/examples/txhotel/bl/HotelReservationSession.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 9
 Error javadoc JavadocMethod Missing a Javadoc comment. 10
 Error javadoc JavadocMethod Missing a Javadoc comment. 12
 Error javadoc JavadocMethod Missing a Javadoc comment. 14
 Error javadoc JavadocMethod Missing a Javadoc comment. 16

ejava/examples/txhotel/bl/HotelReservationist.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocType Missing a Javadoc comment. 9
 Error javadoc JavadocMethod Missing a Javadoc comment. 10
 Error javadoc JavadocMethod Missing a Javadoc comment. 12
 Error regexp RegexpSingleline Line has trailing spaces. 14
 Error javadoc JavadocMethod Missing a Javadoc comment. 14
 Error regexp RegexpSingleline Line has trailing spaces. 17
 Error javadoc JavadocMethod Missing a Javadoc comment. 17
 Error javadoc JavadocMethod Missing a Javadoc comment. 19
 Error javadoc JavadocMethod Missing a Javadoc comment. 21
 Error javadoc JavadocMethod Missing a Javadoc comment. 24

ejava/examples/txhotel/bl/InvalidParameterException.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 3
 Error javadoc JavadocMethod Missing a Javadoc comment. 5
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 5
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 5
 Error misc FinalParameters Parameter msg should be final. 6
 Error blocks LeftCurly '{' at column 50 should have line break after. 6
 Error misc FinalParameters Parameter msg should be final. 7
 Error misc FinalParameters Parameter ex should be final. 7
 Error blocks LeftCurly '{' at column 64 should have line break after. 7
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 7
 Error whitespace WhitespaceAfter ';' is not followed by whitespace. 7
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 7
 Error misc FinalParameters Parameter ex should be final. 8
 Error blocks LeftCurly '{' at column 52 should have line break after. 8

ejava/examples/txhotel/bl/InvalidReservationChangeException.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 3
 Error sizes LineLength Line is longer than 80 characters (found 82). 4
 Error javadoc JavadocMethod Missing a Javadoc comment. 5
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 5
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 5
 Error misc FinalParameters Parameter msg should be final. 6
 Error blocks LeftCurly '{' at column 58 should have line break after. 6
 Error sizes LineLength Line is longer than 80 characters (found 88). 7
 Error misc FinalParameters Parameter msg should be final. 7
 Error misc FinalParameters Parameter ex should be final. 7
 Error blocks LeftCurly '{' at column 72 should have line break after. 7
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 7
 Error whitespace WhitespaceAfter ';' is not followed by whitespace. 7
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 7
 Error misc FinalParameters Parameter ex should be final. 8
 Error blocks LeftCurly '{' at column 60 should have line break after. 8

ejava/examples/txhotel/bl/ReservationNotFoundException.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 3
 Error javadoc JavadocMethod Missing a Javadoc comment. 5
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 5
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 5
 Error misc FinalParameters Parameter msg should be final. 6
 Error blocks LeftCurly '{' at column 53 should have line break after. 6
 Error sizes LineLength Line is longer than 80 characters (found 83). 7
 Error misc FinalParameters Parameter msg should be final. 7
 Error misc FinalParameters Parameter ex should be final. 7
 Error blocks LeftCurly '{' at column 67 should have line break after. 7
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 7
 Error whitespace WhitespaceAfter ';' is not followed by whitespace. 7
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 7
 Error misc FinalParameters Parameter ex should be final. 8
 Error blocks LeftCurly '{' at column 55 should have line break after. 8

ejava/examples/txhotel/bo/Person.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline.
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocType Missing a Javadoc comment. 6
 Error javadoc JavadocVariable Missing a Javadoc comment. 8
 Error javadoc JavadocVariable Missing a Javadoc comment. 9
 Error javadoc JavadocVariable Missing a Javadoc comment. 10
 Error javadoc JavadocVariable Missing a Javadoc comment. 11
 Error javadoc JavadocVariable Missing a Javadoc comment. 12
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 12
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 12
 Error regexp RegexpSingleline Line has trailing spaces. 13
 Error javadoc JavadocMethod Missing a Javadoc comment. 14
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 14
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 14
 Error regexp RegexpSingleline Line has trailing spaces. 15
 Error javadoc JavadocMethod Missing a Javadoc comment. 15
 Error misc FinalParameters Parameter id should be final. 15
 Error coding HiddenField 'id' hides a field. 15
 Error misc FinalParameters Parameter version should be final. 15
 Error coding HiddenField 'version' hides a field. 15
 Error misc FinalParameters Parameter firstName should be final. 15
 Error coding HiddenField 'firstName' hides a field. 15
 Error misc FinalParameters Parameter lastName should be final. 15
 Error coding HiddenField 'lastName' hides a field. 15
 Error regexp RegexpSingleline Line has trailing spaces. 21
 Error design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 22
 Error javadoc JavadocMethod Missing a Javadoc comment. 22
 Error javadoc JavadocMethod Missing a Javadoc comment. 25
 Error misc FinalParameters Parameter id should be final. 25
 Error coding HiddenField 'id' hides a field. 25
 Error design DesignForExtension Method 'getFirstName' is not designed for extension - needs to be abstract, final or empty. 28
 Error javadoc JavadocMethod Missing a Javadoc comment. 28
 Error design DesignForExtension Method 'setFirstName' is not designed for extension - needs to be abstract, final or empty. 31
 Error javadoc JavadocMethod Missing a Javadoc comment. 31
 Error misc FinalParameters Parameter firstName should be final. 31
 Error coding HiddenField 'firstName' hides a field. 31
 Error design DesignForExtension Method 'getLastName' is not designed for extension - needs to be abstract, final or empty. 34
 Error javadoc JavadocMethod Missing a Javadoc comment. 34
 Error design DesignForExtension Method 'setLastName' is not designed for extension - needs to be abstract, final or empty. 37
 Error javadoc JavadocMethod Missing a Javadoc comment. 37
 Error misc FinalParameters Parameter lastName should be final. 37
 Error coding HiddenField 'lastName' hides a field. 37
 Error regexp RegexpSingleline Line has trailing spaces. 39
 Error design DesignForExtension Method 'getVersion' is not designed for extension - needs to be abstract, final or empty. 40
 Error javadoc JavadocMethod Missing a Javadoc comment. 40
 Error design DesignForExtension Method 'setVersion' is not designed for extension - needs to be abstract, final or empty. 43
 Error javadoc JavadocMethod Missing a Javadoc comment. 43
 Error misc FinalParameters Parameter version should be final. 43
 Error coding HiddenField 'version' hides a field. 43
 Error regexp RegexpSingleline Line has trailing spaces. 46
 Error design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 47
 Error whitespace FileTabCharacter File contains tab characters (this is the first instance). 48
 Error misc FinalParameters Parameter obj should be final. 48
 Error blocks NeedBraces 'if' construct must use '{}'s. 50
 Error whitespace WhitespaceAround '==' is not preceded with whitespace. 50
 Error whitespace WhitespaceAround '==' is not followed by whitespace. 50
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 51
 Error whitespace WhitespaceAround '==' is not preceded with whitespace. 52
 Error whitespace WhitespaceAround '==' is not followed by whitespace. 52
 Error whitespace OperatorWrap '&&' should be on a new line. 52
 Error whitespace OperatorWrap '&&' should be on a new line. 53
 Error design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 59
 Error regexp RegexpSingleline Line has trailing spaces. 63
 Error design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 64
 Error javadoc JavadocMethod Missing a Javadoc comment. 64

ejava/examples/txhotel/bo/Reservation.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 8
 Error javadoc JavadocVariable Missing a Javadoc comment. 10
 Error javadoc JavadocVariable Missing a Javadoc comment. 11
 Error javadoc JavadocVariable Missing a Javadoc comment. 12
 Error javadoc JavadocVariable Missing a Javadoc comment. 13
 Error javadoc JavadocVariable Missing a Javadoc comment. 14
 Error javadoc JavadocVariable Missing a Javadoc comment. 15
 Error regexp RegexpSingleline Line has trailing spaces. 16
 Error javadoc JavadocMethod Missing a Javadoc comment. 17
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 17
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 17
 Error javadoc JavadocMethod Missing a Javadoc comment. 18
 Error misc FinalParameters Parameter id should be final. 19
 Error coding HiddenField 'id' hides a field. 19
 Error misc FinalParameters Parameter version should be final. 19
 Error coding HiddenField 'version' hides a field. 19
 Error misc FinalParameters Parameter confirmation should be final. 19
 Error coding HiddenField 'confirmation' hides a field. 19
 Error misc FinalParameters Parameter person should be final. 19
 Error coding HiddenField 'person' hides a field. 19
 Error misc FinalParameters Parameter startDate should be final. 20
 Error coding HiddenField 'startDate' hides a field. 20
 Error misc FinalParameters Parameter endDate should be final. 20
 Error coding HiddenField 'endDate' hides a field. 20
 Error regexp RegexpSingleline Line has trailing spaces. 24
 Error regexp RegexpSingleline Line has trailing spaces. 28
 Error design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 29
 Error javadoc JavadocMethod Missing a Javadoc comment. 29
 Error javadoc JavadocMethod Missing a Javadoc comment. 32
 Error misc FinalParameters Parameter id should be final. 32
 Error coding HiddenField 'id' hides a field. 32
 Error design DesignForExtension Method 'getConfirmation' is not designed for extension - needs to be abstract, final or empty. 35
 Error javadoc JavadocMethod Missing a Javadoc comment. 35
 Error design DesignForExtension Method 'setConfirmation' is not designed for extension - needs to be abstract, final or empty. 38
 Error javadoc JavadocMethod Missing a Javadoc comment. 38
 Error misc FinalParameters Parameter confirmation should be final. 38
 Error coding HiddenField 'confirmation' hides a field. 38
 Error design DesignForExtension Method 'getPerson' is not designed for extension - needs to be abstract, final or empty. 41
 Error javadoc JavadocMethod Missing a Javadoc comment. 41
 Error design DesignForExtension Method 'setPerson' is not designed for extension - needs to be abstract, final or empty. 44
 Error javadoc JavadocMethod Missing a Javadoc comment. 44
 Error misc FinalParameters Parameter person should be final. 44
 Error coding HiddenField 'person' hides a field. 44
 Error design DesignForExtension Method 'getVersion' is not designed for extension - needs to be abstract, final or empty. 47
 Error javadoc JavadocMethod Missing a Javadoc comment. 47
 Error design DesignForExtension Method 'setVersion' is not designed for extension - needs to be abstract, final or empty. 50
 Error javadoc JavadocMethod Missing a Javadoc comment. 50
 Error misc FinalParameters Parameter version should be final. 50
 Error coding HiddenField 'version' hides a field. 50
 Error design DesignForExtension Method 'getEndDate' is not designed for extension - needs to be abstract, final or empty. 53
 Error javadoc JavadocMethod Missing a Javadoc comment. 53
 Error design DesignForExtension Method 'setEndDate' is not designed for extension - needs to be abstract, final or empty. 56
 Error javadoc JavadocMethod Missing a Javadoc comment. 56
 Error misc FinalParameters Parameter endDate should be final. 56
 Error coding HiddenField 'endDate' hides a field. 56
 Error design DesignForExtension Method 'getStartDate' is not designed for extension - needs to be abstract, final or empty. 59
 Error javadoc JavadocMethod Missing a Javadoc comment. 59
 Error design DesignForExtension Method 'setStartDate' is not designed for extension - needs to be abstract, final or empty. 62
 Error javadoc JavadocMethod Missing a Javadoc comment. 62
 Error misc FinalParameters Parameter startDate should be final. 62
 Error coding HiddenField 'startDate' hides a field. 62
 Error design DesignForExtension Method 'equals' is not designed for extension - needs to be abstract, final or empty. 65
 Error whitespace FileTabCharacter File contains tab characters (this is the first instance). 66
 Error misc FinalParameters Parameter obj should be final. 66
 Error blocks NeedBraces 'if' construct must use '{}'s. 68
 Error whitespace WhitespaceAround '==' is not preceded with whitespace. 68
 Error whitespace WhitespaceAround '==' is not followed by whitespace. 68
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 69
 Error whitespace OperatorWrap '&&' should be on a new line. 70
 Error whitespace OperatorWrap '&&' should be on a new line. 71
 Error whitespace OperatorWrap '&&' should be on a new line. 72
 Error whitespace WhitespaceAround '==' is not preceded with whitespace. 73
 Error whitespace WhitespaceAround '==' is not followed by whitespace. 73
 Error javadoc JavadocMethod Missing a Javadoc comment. 78
 Error misc FinalParameters Parameter lhsDate should be final. 78
 Error misc FinalParameters Parameter rhsDate should be final. 78
 Error regexp RegexpSingleline Line has trailing spaces. 79
 Error whitespace WhitespaceAround '==' is not preceded with whitespace. 79
 Error whitespace WhitespaceAround '==' is not followed by whitespace. 79
 Error whitespace WhitespaceAround '==' is not preceded with whitespace. 79
 Error whitespace WhitespaceAround '==' is not followed by whitespace. 79
 Error blocks RightCurly '}' at column 6 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 81
 Error whitespace WhitespaceAround '==' is not preceded with whitespace. 82
 Error whitespace WhitespaceAround '==' is not followed by whitespace. 82
 Error whitespace WhitespaceAround '==' is not preceded with whitespace. 82
 Error whitespace WhitespaceAround '==' is not followed by whitespace. 82
 Error regexp RegexpSingleline Line has trailing spaces. 85
 Error whitespace WhitespaceAround '==' is not preceded with whitespace. 90
 Error whitespace WhitespaceAround '==' is not followed by whitespace. 90
 Error whitespace OperatorWrap '&&' should be on a new line. 90
 Error sizes LineLength Line is longer than 80 characters (found 93). 91
 Error whitespace WhitespaceAround '==' is not preceded with whitespace. 91
 Error whitespace WhitespaceAround '==' is not followed by whitespace. 91
 Error regexp RegexpSingleline Line has trailing spaces. 93
 Error regexp RegexpSingleline Line has trailing spaces. 94
 Error design DesignForExtension Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. 95
 Error sizes LineLength Line is longer than 80 characters (found 81). 97
 Error whitespace WhitespaceAround '+' is not preceded with whitespace. 97
 Error whitespace WhitespaceAround '+' is not followed by whitespace. 97
 Error whitespace WhitespaceAround '+' is not preceded with whitespace. 97
 Error whitespace WhitespaceAround '+' is not followed by whitespace. 97
 Error regexp RegexpSingleline Line has trailing spaces. 99
 Error design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 100
 Error javadoc JavadocMethod Missing a Javadoc comment. 100