Checkstyle Results

The following document contains the results of Checkstyle 6.18 with sun_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
2 0 0 105

Files

File  I  W  E
ejava/examples/txhotel/blimpl/HotelReservationImpl.java 0 0 77
ejava/examples/txhotel/blimpl/HotelReservationSessionImpl.java 0 0 28

Rules

Category Rule Violations Severity
blocks RightCurly 2  Error
coding HiddenField 2  Error
MagicNumber 1  Error
design DesignForExtension 12  Error
VisibilityModifier 1  Error
javadoc JavadocMethod 13  Error
JavadocPackage 1  Error
JavadocType 1  Error
JavadocVariable 6  Error
misc FinalParameters 18  Error
naming ConstantName 2  Error
regexp RegexpSingleline
  • format: "\s+$"
  • maximum: "0"
  • message: "Line has trailing spaces."
  • minimum: "0"
 30  Error
sizes LineLength 4  Error
whitespace FileTabCharacter 1  Error
OperatorWrap 5  Error
WhitespaceAfter 3  Error
WhitespaceAround 3  Error

Details

ejava/examples/txhotel/blimpl/HotelReservationImpl.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 22
 Error sizes LineLength Line is longer than 80 characters (found 90). 23
 Error javadoc JavadocVariable Missing a Javadoc comment. 23
 Error naming ConstantName Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 23
 Error javadoc JavadocVariable Missing a Javadoc comment. 24
 Error design VisibilityModifier Variable 'dao' must be private and have accessor methods. 24
 Error javadoc JavadocVariable Missing a Javadoc comment. 25
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 25
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 25
 Error regexp RegexpSingleline Line has trailing spaces. 27
 Error design DesignForExtension Method 'getReservation' is not designed for extension - needs to be abstract, final or empty. 27
 Error javadoc JavadocMethod Missing a Javadoc comment. 27
 Error misc FinalParameters Parameter confirmation should be final. 27
 Error regexp RegexpSingleline Line has trailing spaces. 28
 Error regexp RegexpSingleline Line has trailing spaces. 29
 Error regexp RegexpSingleline Line has trailing spaces. 30
 Error regexp RegexpSingleline Line has trailing spaces. 34
 Error whitespace OperatorWrap '+' should be on a new line. 34
 Error regexp RegexpSingleline Line has trailing spaces. 40
 Error design DesignForExtension Method 'cancelReservation' is not designed for extension - needs to be abstract, final or empty. 40
 Error javadoc JavadocMethod Missing a Javadoc comment. 40
 Error misc FinalParameters Parameter reservation should be final. 40
 Error regexp RegexpSingleline Line has trailing spaces. 41
 Error regexp RegexpSingleline Line has trailing spaces. 42
 Error regexp RegexpSingleline Line has trailing spaces. 43
 Error regexp RegexpSingleline Line has trailing spaces. 44
 Error regexp RegexpSingleline Line has trailing spaces. 45
 Error coding MagicNumber '-2' is a magic number. 48
 Error regexp RegexpSingleline Line has trailing spaces. 49
 Error regexp RegexpSingleline Line has trailing spaces. 51
 Error whitespace OperatorWrap '+' should be on a new line. 52
 Error whitespace OperatorWrap '+' should be on a new line. 53
 Error regexp RegexpSingleline Line has trailing spaces. 55
 Error whitespace OperatorWrap '+' should be on a new line. 58
 Error regexp RegexpSingleline Line has trailing spaces. 59
 Error whitespace OperatorWrap '+' should be on a new line. 59
 Error regexp RegexpSingleline Line has trailing spaces. 62
 Error regexp RegexpSingleline Line has trailing spaces. 63
 Error regexp RegexpSingleline Line has trailing spaces. 66
 Error design DesignForExtension Method 'commitReservation' is not designed for extension - needs to be abstract, final or empty. 66
 Error javadoc JavadocMethod Missing a Javadoc comment. 66
 Error misc FinalParameters Parameter reservation should be final. 66
 Error regexp RegexpSingleline Line has trailing spaces. 68
 Error design DesignForExtension Method 'createReservation' is not designed for extension - needs to be abstract, final or empty. 73
 Error javadoc JavadocMethod Missing a Javadoc comment. 73
 Error regexp RegexpSingleline Line has trailing spaces. 74
 Error misc FinalParameters Parameter person should be final. 74
 Error misc FinalParameters Parameter startDate should be final. 74
 Error misc FinalParameters Parameter endDate should be final. 74
 Error regexp RegexpSingleline Line has trailing spaces. 76
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 80
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 83
 Error regexp RegexpSingleline Line has trailing spaces. 87
 Error regexp RegexpSingleline Line has trailing spaces. 95
 Error design DesignForExtension Method 'getReservations' is not designed for extension - needs to be abstract, final or empty. 95
 Error javadoc JavadocMethod Missing a Javadoc comment. 95
 Error misc FinalParameters Parameter index should be final. 95
 Error misc FinalParameters Parameter count should be final. 95
 Error design DesignForExtension Method 'getReservationsForPerson' is not designed for extension - needs to be abstract, final or empty. 100
 Error javadoc JavadocMethod Missing a Javadoc comment. 100
 Error regexp RegexpSingleline Line has trailing spaces. 101
 Error misc FinalParameters Parameter person should be final. 101
 Error misc FinalParameters Parameter index should be final. 101
 Error misc FinalParameters Parameter count should be final. 101
 Error regexp RegexpSingleline Line has trailing spaces. 106
 Error regexp RegexpSingleline Line has trailing spaces. 110
 Error design DesignForExtension Method 'cleanupReservation' is not designed for extension - needs to be abstract, final or empty. 110
 Error javadoc JavadocMethod Missing a Javadoc comment. 110
 Error misc FinalParameters Parameter confirmation should be final. 110
 Error design DesignForExtension Method 'setDao' is not designed for extension - needs to be abstract, final or empty. 120
 Error javadoc JavadocMethod Missing a Javadoc comment. 120
 Error misc FinalParameters Parameter dao should be final. 120
 Error coding HiddenField 'dao' hides a field. 120
 Error regexp RegexpSingleline Line has trailing spaces. 124
 Error design DesignForExtension Method 'getReservationByConfirmation' is not designed for extension - needs to be abstract, final or empty. 124
 Error javadoc JavadocMethod Missing a Javadoc comment. 124
 Error misc FinalParameters Parameter confirmation should be final. 124

ejava/examples/txhotel/blimpl/HotelReservationSessionImpl.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error sizes LineLength Line is longer than 80 characters (found 97). 22
 Error javadoc JavadocVariable Missing a Javadoc comment. 22
 Error naming ConstantName Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 22
 Error javadoc JavadocVariable Missing a Javadoc comment. 23
 Error javadoc JavadocVariable Missing a Javadoc comment. 24
 Error design DesignForExtension Method 'createReservation' is not designed for extension - needs to be abstract, final or empty. 26
 Error javadoc JavadocMethod Missing a Javadoc comment. 26
 Error misc FinalParameters Parameter person should be final. 26
 Error misc FinalParameters Parameter startDate should be final. 26
 Error misc FinalParameters Parameter endDate should be final. 26
 Error regexp RegexpSingleline Line has trailing spaces. 28
 Error sizes LineLength Line is longer than 80 characters (found 82). 28
 Error whitespace WhitespaceAfter ',' is not followed by whitespace. 28
 Error whitespace WhitespaceAfter ',' is not followed by whitespace. 28
 Error whitespace WhitespaceAfter ',' is not followed by whitespace. 28
 Error whitespace FileTabCharacter File contains tab characters (this is the first instance). 29
 Error regexp RegexpSingleline Line has trailing spaces. 31
 Error javadoc JavadocMethod Missing a Javadoc comment. 32
 Error design DesignForExtension Method 'commit' is not designed for extension - needs to be abstract, final or empty. 35
 Error javadoc JavadocMethod Missing a Javadoc comment. 35
 Error sizes LineLength Line is longer than 80 characters (found 82). 36
 Error whitespace WhitespaceAround 'for' is not followed by whitespace. 38
 Error design DesignForExtension Method 'setReservationist' is not designed for extension - needs to be abstract, final or empty. 48
 Error javadoc JavadocMethod Missing a Javadoc comment. 48
 Error misc FinalParameters Parameter reservationist should be final. 48
 Error coding HiddenField 'reservationist' hides a field. 48
 Error regexp RegexpSingleline Line has trailing spaces. 51