Checkstyle Results

The following document contains the results of Checkstyle 6.18 with sun_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
8 0 0 239

Files

File  I  W  E
ejava/examples/ejbsessionbank/dto/OwnerDTO.java 0 0 49
ejava/examples/ejbsessionbank/ejb/Stats.java 0 0 7
ejava/examples/ejbsessionbank/ejb/StatsEJB.java 0 0 30
ejava/examples/ejbsessionbank/ejb/StatsLocal.java 0 0 1
ejava/examples/ejbsessionbank/ejb/StatsRemote.java 0 0 1
ejava/examples/ejbsessionbank/ejb/TellerEJB.java 0 0 144
ejava/examples/ejbsessionbank/ejb/TellerLocal.java 0 0 1
ejava/examples/ejbsessionbank/ejb/TellerRemote.java 0 0 6

Rules

Category Rule Violations Severity
blocks EmptyBlock 1  Error
RightCurly 17  Error
coding HiddenField 9  Error
MagicNumber 1  Error
design DesignForExtension 37  Error
VisibilityModifier 4  Error
javadoc JavadocMethod 47  Error
JavadocPackage 2  Error
JavadocType 6  Error
JavadocVariable 12  Error
misc FinalParameters 33  Error
naming ConstantName 2  Error
regexp RegexpSingleline
  • format: "\s+$"
  • maximum: "0"
  • message: "Line has trailing spaces."
  • minimum: "0"
 38  Error
sizes LineLength 7  Error
whitespace FileTabCharacter 3  Error
WhitespaceAfter 5  Error
WhitespaceAround 15  Error

Details

ejava/examples/ejbsessionbank/dto/OwnerDTO.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocType Missing a Javadoc comment. 5
 Error javadoc JavadocVariable Missing a Javadoc comment. 7
 Error javadoc JavadocVariable Missing a Javadoc comment. 8
 Error javadoc JavadocVariable Missing a Javadoc comment. 9
 Error javadoc JavadocVariable Missing a Javadoc comment. 10
 Error javadoc JavadocMethod Missing a Javadoc comment. 12
 Error whitespace WhitespaceAround '{' is not followed by whitespace. 12
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 12
 Error javadoc JavadocMethod Missing a Javadoc comment. 13
 Error misc FinalParameters Parameter id should be final. 13
 Error coding HiddenField 'id' hides a field. 13
 Error javadoc JavadocMethod Missing a Javadoc comment. 16
 Error misc FinalParameters Parameter id should be final. 16
 Error coding HiddenField 'id' hides a field. 16
 Error misc FinalParameters Parameter firstName should be final. 16
 Error coding HiddenField 'firstName' hides a field. 16
 Error misc FinalParameters Parameter lastName should be final. 16
 Error coding HiddenField 'lastName' hides a field. 16
 Error misc FinalParameters Parameter accounts should be final. 16
 Error coding HiddenField 'accounts' hides a field. 16
 Error regexp RegexpSingleline Line has trailing spaces. 22
 Error design DesignForExtension Method 'getId' is not designed for extension - needs to be abstract, final or empty. 23
 Error javadoc JavadocMethod Missing a Javadoc comment. 23
 Error design DesignForExtension Method 'setId' is not designed for extension - needs to be abstract, final or empty. 26
 Error javadoc JavadocMethod Missing a Javadoc comment. 26
 Error misc FinalParameters Parameter id should be final. 26
 Error coding HiddenField 'id' hides a field. 26
 Error design DesignForExtension Method 'getFirstName' is not designed for extension - needs to be abstract, final or empty. 29
 Error javadoc JavadocMethod Missing a Javadoc comment. 29
 Error design DesignForExtension Method 'setFirstName' is not designed for extension - needs to be abstract, final or empty. 32
 Error javadoc JavadocMethod Missing a Javadoc comment. 32
 Error misc FinalParameters Parameter firstName should be final. 32
 Error coding HiddenField 'firstName' hides a field. 32
 Error design DesignForExtension Method 'getLastName' is not designed for extension - needs to be abstract, final or empty. 35
 Error javadoc JavadocMethod Missing a Javadoc comment. 35
 Error design DesignForExtension Method 'setLastName' is not designed for extension - needs to be abstract, final or empty. 38
 Error javadoc JavadocMethod Missing a Javadoc comment. 38
 Error misc FinalParameters Parameter lastName should be final. 38
 Error coding HiddenField 'lastName' hides a field. 38
 Error design DesignForExtension Method 'getAccounts' is not designed for extension - needs to be abstract, final or empty. 41
 Error javadoc JavadocMethod Missing a Javadoc comment. 41
 Error design DesignForExtension Method 'setAccounts' is not designed for extension - needs to be abstract, final or empty. 44
 Error javadoc JavadocMethod Missing a Javadoc comment. 44
 Error misc FinalParameters Parameter accounts should be final. 44
 Error coding HiddenField 'accounts' hides a field. 44
 Error regexp RegexpSingleline Line has trailing spaces. 47
 Error design DesignForExtension Method 'toString' is not designed for extension - needs to be abstract, final or empty. 48
 Error javadoc JavadocMethod Missing a Javadoc comment. 48

ejava/examples/ejbsessionbank/ejb/Stats.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 3
 Error whitespace FileTabCharacter File contains tab characters (this is the first instance). 4
 Error javadoc JavadocMethod Missing a Javadoc comment. 4
 Error javadoc JavadocMethod Missing a Javadoc comment. 5
 Error javadoc JavadocMethod Missing a Javadoc comment. 6
 Error javadoc JavadocMethod Missing a Javadoc comment. 7
 Error javadoc JavadocMethod Missing a Javadoc comment. 8

ejava/examples/ejbsessionbank/ejb/StatsEJB.java

Severity Category Rule Message Line
 Error regexp RegexpSingleline Line has trailing spaces. 24
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 28
 Error coding MagicNumber '3000' is a magic number. 28
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 28
 Error whitespace FileTabCharacter File contains tab characters (this is the first instance). 30
 Error javadoc JavadocVariable Missing a Javadoc comment. 30
 Error naming ConstantName Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 30
 Error javadoc JavadocVariable Missing a Javadoc comment. 31
 Error javadoc JavadocVariable Missing a Javadoc comment. 32
 Error regexp RegexpSingleline Line has trailing spaces. 33
 Error design DesignForExtension Method 'init' is not designed for extension - needs to be abstract, final or empty. 34
 Error javadoc JavadocMethod Missing a Javadoc comment. 34
 Error design DesignForExtension Method 'open' is not designed for extension - needs to be abstract, final or empty. 43
 Error sizes LineLength Line is longer than 80 characters (found 83). 48
 Error regexp RegexpSingleline Line has trailing spaces. 50
 Error design DesignForExtension Method 'close' is not designed for extension - needs to be abstract, final or empty. 51
 Error sizes LineLength Line is longer than 80 characters (found 84). 56
 Error regexp RegexpSingleline Line has trailing spaces. 57
 Error regexp RegexpSingleline Line has trailing spaces. 58
 Error design DesignForExtension Method 'getTotal' is not designed for extension - needs to be abstract, final or empty. 63
 Error sizes LineLength Line is longer than 80 characters (found 87). 66
 Error design DesignForExtension Method 'getDelta' is not designed for extension - needs to be abstract, final or empty. 70
 Error sizes LineLength Line is longer than 80 characters (found 87). 73
 Error regexp RegexpSingleline Line has trailing spaces. 76
 Error design DesignForExtension Method 'reset' is not designed for extension - needs to be abstract, final or empty. 77
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 80
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 80
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 81
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 81
 Error sizes LineLength Line is longer than 80 characters (found 84). 82

ejava/examples/ejbsessionbank/ejb/StatsLocal.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 5

ejava/examples/ejbsessionbank/ejb/StatsRemote.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 5

ejava/examples/ejbsessionbank/ejb/TellerEJB.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error regexp RegexpSingleline Line has trailing spaces. 33
 Error regexp RegexpSingleline Line has trailing spaces. 34
 Error regexp RegexpSingleline Line has trailing spaces. 39
 Error javadoc JavadocVariable Missing a Javadoc comment. 43
 Error naming ConstantName Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 43
 Error javadoc JavadocVariable Missing a Javadoc comment. 45
 Error design VisibilityModifier Variable 'ctx' must be private and have accessor methods. 46
 Error regexp RegexpSingleline Line has trailing spaces. 47
 Error regexp RegexpSingleline Line has trailing spaces. 48
 Error regexp RegexpSingleline Line has trailing spaces. 50
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 51
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 51
 Error design VisibilityModifier Variable 'em' must be private and have accessor methods. 52
 Error regexp RegexpSingleline Line has trailing spaces. 53
 Error javadoc JavadocVariable Missing a Javadoc comment. 54
 Error whitespace WhitespaceAround '=' is not preceded with whitespace. 54
 Error whitespace WhitespaceAround '=' is not followed by whitespace. 54
 Error design VisibilityModifier Variable 'daoClassName' must be private and have accessor methods. 55
 Error regexp RegexpSingleline Line has trailing spaces. 56
 Error javadoc JavadocVariable Missing a Javadoc comment. 57
 Error javadoc JavadocVariable Missing a Javadoc comment. 60
 Error design VisibilityModifier Variable 'teller' must be private and have accessor methods. 60
 Error regexp RegexpSingleline Line has trailing spaces. 61
 Error regexp RegexpSingleline Line has trailing spaces. 64
 Error design DesignForExtension Method 'init' is not designed for extension - needs to be abstract, final or empty. 67
 Error regexp RegexpSingleline Line has trailing spaces. 71
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 73
 Error regexp RegexpSingleline Line has trailing spaces. 76
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 77
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 78
 Error regexp RegexpSingleline Line has trailing spaces. 79
 Error regexp RegexpSingleline Line has trailing spaces. 81
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 81
 Error whitespace WhitespaceAfter 'typecast' is not followed by whitespace. 82
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 83
 Error regexp RegexpSingleline Line has trailing spaces. 86
 Error regexp RegexpSingleline Line has trailing spaces. 89
 Error regexp RegexpSingleline Line has trailing spaces. 93
 Error regexp RegexpSingleline Line has trailing spaces. 94
 Error design DesignForExtension Method 'close' is not designed for extension - needs to be abstract, final or empty. 98
 Error design DesignForExtension Method 'createAccount' is not designed for extension - needs to be abstract, final or empty. 104
 Error javadoc JavadocMethod Missing a Javadoc comment. 104
 Error misc FinalParameters Parameter accountNumber should be final. 104
 Error whitespace FileTabCharacter File contains tab characters (this is the first instance). 107
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 110
 Error regexp RegexpSingleline Line has trailing spaces. 117
 Error design DesignForExtension Method 'closeAccount' is not designed for extension - needs to be abstract, final or empty. 118
 Error javadoc JavadocMethod Missing a Javadoc comment. 118
 Error misc FinalParameters Parameter acctNum should be final. 118
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 124
 Error design DesignForExtension Method 'getAccount' is not designed for extension - needs to be abstract, final or empty. 132
 Error javadoc JavadocMethod Missing a Javadoc comment. 132
 Error misc FinalParameters Parameter acctNum should be final. 132
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 136
 Error sizes LineLength Line is longer than 80 characters (found 90). 144
 Error design DesignForExtension Method 'getOverdrawnAccounts' is not designed for extension - needs to be abstract, final or empty. 144
 Error javadoc JavadocMethod Missing a Javadoc comment. 144
 Error misc FinalParameters Parameter index should be final. 144
 Error misc FinalParameters Parameter count should be final. 144
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 148
 Error sizes LineLength Line is longer than 80 characters (found 81). 156
 Error design DesignForExtension Method 'getAccounts' is not designed for extension - needs to be abstract, final or empty. 156
 Error javadoc JavadocMethod Missing a Javadoc comment. 156
 Error misc FinalParameters Parameter index should be final. 156
 Error misc FinalParameters Parameter count should be final. 156
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 160
 Error design DesignForExtension Method 'updateAccount' is not designed for extension - needs to be abstract, final or empty. 168
 Error javadoc JavadocMethod Missing a Javadoc comment. 168
 Error misc FinalParameters Parameter account should be final. 168
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 173
 Error design DesignForExtension Method 'getLedger' is not designed for extension - needs to be abstract, final or empty. 181
 Error javadoc JavadocMethod Missing a Javadoc comment. 181
 Error regexp RegexpSingleline Line has trailing spaces. 187
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 189
 Error javadoc JavadocMethod Expected an @return tag. 202
 Error design DesignForExtension Method 'getLedger2' is not designed for extension - needs to be abstract, final or empty. 202
 Error javadoc JavadocMethod Expected @throws tag for 'BankException'. 202
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 206
 Error regexp RegexpSingleline Line has trailing spaces. 213
 Error regexp RegexpSingleline Line has trailing spaces. 215
 Error javadoc JavadocMethod Expected an @return tag. 218
 Error design DesignForExtension Method 'getLedgerAveBalance' is not designed for extension - needs to be abstract, final or empty. 218
 Error javadoc JavadocMethod Expected @throws tag for 'BankException'. 218
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 222
 Error regexp RegexpSingleline Line has trailing spaces. 232
 Error javadoc JavadocMethod Expected an @return tag. 235
 Error design DesignForExtension Method 'getLedgerCount' is not designed for extension - needs to be abstract, final or empty. 235
 Error javadoc JavadocMethod Expected @throws tag for 'BankException'. 235
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 239
 Error regexp RegexpSingleline Line has trailing spaces. 249
 Error javadoc JavadocMethod Expected an @return tag. 252
 Error design DesignForExtension Method 'getLedgerSum' is not designed for extension - needs to be abstract, final or empty. 252
 Error javadoc JavadocMethod Expected @throws tag for 'BankException'. 252
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 256
 Error regexp RegexpSingleline Line has trailing spaces. 264
 Error javadoc JavadocMethod Missing a Javadoc comment. 265
 Error blocks EmptyBlock Must have at least one statement. 266
 Error regexp RegexpSingleline Line has trailing spaces. 270
 Error design DesignForExtension Method 'addOwner' is not designed for extension - needs to be abstract, final or empty. 274
 Error javadoc JavadocMethod Missing a Javadoc comment. 274
 Error misc FinalParameters Parameter ownerId should be final. 274
 Error misc FinalParameters Parameter accountNumber should be final. 274
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 279
 Error design DesignForExtension Method 'createOwner' is not designed for extension - needs to be abstract, final or empty. 287
 Error javadoc JavadocMethod Missing a Javadoc comment. 287
 Error misc FinalParameters Parameter firstName should be final. 287
 Error misc FinalParameters Parameter lastName should be final. 287
 Error misc FinalParameters Parameter ssn should be final. 287
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 292
 Error design DesignForExtension Method 'openAccount' is not designed for extension - needs to be abstract, final or empty. 300
 Error javadoc JavadocMethod Missing a Javadoc comment. 300
 Error misc FinalParameters Parameter ownerId should be final. 300
 Error misc FinalParameters Parameter accountNumber should be final. 300
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 305
 Error design DesignForExtension Method 'removeOwner' is not designed for extension - needs to be abstract, final or empty. 313
 Error javadoc JavadocMethod Missing a Javadoc comment. 313
 Error misc FinalParameters Parameter ownerId should be final. 313
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 317
 Error design DesignForExtension Method 'getOwners' is not designed for extension - needs to be abstract, final or empty. 325
 Error javadoc JavadocMethod Missing a Javadoc comment. 325
 Error misc FinalParameters Parameter index should be final. 325
 Error misc FinalParameters Parameter count should be final. 325
 Error blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 329
 Error regexp RegexpSingleline Line has trailing spaces. 337
 Error design DesignForExtension Method 'getOwnersLoaded' is not designed for extension - needs to be abstract, final or empty. 337
 Error javadoc JavadocMethod Missing a Javadoc comment. 337
 Error misc FinalParameters Parameter index should be final. 337
 Error misc FinalParameters Parameter count should be final. 337
 Error whitespace WhitespaceAround 'for' is not followed by whitespace. 340
 Error regexp RegexpSingleline Line has trailing spaces. 347
 Error regexp RegexpSingleline Line has trailing spaces. 348
 Error design DesignForExtension Method 'getOwnersPOJO' is not designed for extension - needs to be abstract, final or empty. 348
 Error javadoc JavadocMethod Missing a Javadoc comment. 348
 Error misc FinalParameters Parameter index should be final. 348
 Error misc FinalParameters Parameter count should be final. 348
 Error whitespace WhitespaceAround 'for' is not followed by whitespace. 351
 Error regexp RegexpSingleline Line has trailing spaces. 367
 Error design DesignForExtension Method 'getOwnersDTO' is not designed for extension - needs to be abstract, final or empty. 367
 Error javadoc JavadocMethod Missing a Javadoc comment. 367
 Error misc FinalParameters Parameter index should be final. 367
 Error misc FinalParameters Parameter count should be final. 367
 Error whitespace WhitespaceAround 'for' is not followed by whitespace. 370
 Error design DesignForExtension Method 'whoAmI' is not designed for extension - needs to be abstract, final or empty. 380

ejava/examples/ejbsessionbank/ejb/TellerLocal.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 7

ejava/examples/ejbsessionbank/ejb/TellerRemote.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 13
 Error javadoc JavadocMethod Missing a Javadoc comment. 15
 Error javadoc JavadocMethod Missing a Javadoc comment. 16
 Error javadoc JavadocMethod Missing a Javadoc comment. 17
 Error javadoc JavadocMethod Missing a Javadoc comment. 18
 Error javadoc JavadocMethod Missing a Javadoc comment. 19